WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116630
fourthTier: It should be possible to use more than one compiler thread
https://bugs.webkit.org/show_bug.cgi?id=116630
Summary
fourthTier: It should be possible to use more than one compiler thread
Filip Pizlo
Reported
2013-05-22 12:42:28 PDT
Patch forthcoming.
Attachments
the patch
(11.08 KB, patch)
2013-05-22 12:45 PDT
,
Filip Pizlo
mhahnenberg
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2013-05-22 12:45:31 PDT
Created
attachment 202614
[details]
the patch
Filip Pizlo
Comment 2
2013-05-22 12:46:39 PDT
Comment on
attachment 202614
[details]
the patch View in context:
https://bugs.webkit.org/attachment.cgi?id=202614&action=review
> Source/JavaScriptCore/runtime/SymbolTable.h:371 > { > - ConcurrentJITLocker locker(m_lock); > - return get(locker, key); > + SymbolTableEntry result; > + { > + ConcurrentJITLocker locker(m_lock); > + result = get(locker, key); > + } > + return result; > } >
I'll investigate if this is necessary.
Mark Hahnenberg
Comment 3
2013-05-22 12:56:26 PDT
Comment on
attachment 202614
[details]
the patch r=me as long as reverting the symbol table stuff is okay to revert.
Filip Pizlo
Comment 4
2013-05-22 13:41:48 PDT
Landed in
http://trac.webkit.org/changeset/150536
Filip Pizlo
Comment 5
2013-05-22 13:42:20 PDT
(In reply to
comment #2
)
> (From update of
attachment 202614
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=202614&action=review
> > > Source/JavaScriptCore/runtime/SymbolTable.h:371 > > { > > - ConcurrentJITLocker locker(m_lock); > > - return get(locker, key); > > + SymbolTableEntry result; > > + { > > + ConcurrentJITLocker locker(m_lock); > > + result = get(locker, key); > > + } > > + return result; > > } > > > > I'll investigate if this is necessary.
And it wasn't necessary. I backed this out before landing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug