Bug 116630 – fourthTier: It should be possible to use more than one compiler thread

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 202614 [details]
the patch

[Filip Pizlo]

Comment on attachment 202614 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202614&action=review

> Source/JavaScriptCore/runtime/SymbolTable.h:371
>      {
> -        ConcurrentJITLocker locker(m_lock);
> -        return get(locker, key);
> +        SymbolTableEntry result;
> +        {
> +            ConcurrentJITLocker locker(m_lock);
> +            result = get(locker, key);
> +        }
> +        return result;
>      }
>      

I'll investigate if this is necessary.

[Mark Hahnenberg]

Comment on attachment 202614 [details]
the patch

r=me as long as reverting the symbol table stuff is okay to revert.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/150536

[Filip Pizlo]

(In reply to comment #2)
> (From update of attachment 202614 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202614&action=review
> 
> > Source/JavaScriptCore/runtime/SymbolTable.h:371
> >      {
> > -        ConcurrentJITLocker locker(m_lock);
> > -        return get(locker, key);
> > +        SymbolTableEntry result;
> > +        {
> > +            ConcurrentJITLocker locker(m_lock);
> > +            result = get(locker, key);
> > +        }
> > +        return result;
> >      }
> >      
> 
> I'll investigate if this is necessary.

And it wasn't necessary.  I backed this out before landing.