WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 116625
[wk2] Should be able to make tiled WKViews clip to the view's exposed rect without using autolayout
https://bugs.webkit.org/show_bug.cgi?id=116625
Summary
[wk2] Should be able to make tiled WKViews clip to the view's exposed rect wi...
Tim Horton
Reported
2013-05-22 11:42:14 PDT
The two modes are not dependent, we just have had no reason to enable them separately before.
Attachments
patch
(5.35 KB, patch)
2013-05-22 11:53 PDT
,
Tim Horton
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-05-22 11:44:04 PDT
<
rdar://problem/13962816
>
Tim Horton
Comment 2
2013-05-22 11:53:02 PDT
Created
attachment 202608
[details]
patch
WebKit Commit Bot
Comment 3
2013-05-22 11:55:17 PDT
Attachment 202608
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h']" exit_code: 1 Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 4
2013-05-22 11:56:12 PDT
Comment on
attachment 202608
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=202608&action=review
>> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:63 >> +@property (readwrite) BOOL shouldClipToExposedRect; > > Extra space before ( in function call [whitespace/parens] [4]
False.
Anders Carlsson
Comment 5
2013-05-22 12:32:03 PDT
Comment on
attachment 202608
[details]
patch I think we should call the API “shouldClipToVisibleRect”.
Tim Horton
Comment 6
2013-05-22 12:48:48 PDT
https://trac.webkit.org/r150532
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug