Bug 116619 - [Qt][Mac] Remove Carbon and QuickDraw support for plugins.
Summary: [Qt][Mac] Remove Carbon and QuickDraw support for plugins.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks: 116620
  Show dependency tree / graph
 
Reported: 2013-05-22 09:26 PDT by Jocelyn Turcotte
Modified: 2013-06-03 06:51 PDT (History)
8 users (show)

See Also:

Attachments
Patch (34.88 KB, patch)
2013-05-22 09:33 PDT, Jocelyn Turcotte 		no flags Details | Formatted Diff | Diff
Patch (34.83 KB, patch)
2013-05-22 10:25 PDT, Jocelyn Turcotte 		vestbo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2013-05-22 09:26:17 PDT 
[Qt][Mac] Remove Carbon and QuickDraw support for plugins.
Comment 1 Jocelyn Turcotte 2013-05-22 09:33:08 PDT 
Created attachment 202569 [details]
Patch
Comment 2 EFL EWS Bot 2013-05-22 09:36:47 PDT 
Comment on attachment 202569 [details]
Patch

Attachment 202569 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/557189
Comment 3 Early Warning System Bot 2013-05-22 09:39:01 PDT 
Comment on attachment 202569 [details]
Patch

Attachment 202569 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/551208
Comment 4 Early Warning System Bot 2013-05-22 09:39:55 PDT 
Comment on attachment 202569 [details]
Patch

Attachment 202569 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/544200
Comment 5 kov's GTK+ EWS bot 2013-05-22 09:41:02 PDT 
Comment on attachment 202569 [details]
Patch

Attachment 202569 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/551210
Comment 6 Build Bot 2013-05-22 09:58:49 PDT 
Comment on attachment 202569 [details]
Patch

Attachment 202569 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/556185
Comment 7 Jocelyn Turcotte 2013-05-22 10:25:04 PDT 
Created attachment 202571 [details]
Patch

Just remove the NP_NO_CARBON guard around dispatchNPEvent, not the declaration itself (I don't think it's worth putting it into ! defined(XP_MACOSX)).
Comment 8 Jocelyn Turcotte 2013-06-03 06:51:57 PDT 
Committed r151106: <http://trac.webkit.org/changeset/151106>