Bug 116612 – [Qt][Mips] r150484 broke the build

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zoltan Arvai]

After the patch something went wrong on Qt Mips:

/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp: In member function 'WebKit::PluginProcessProxy* WebKit::PluginProcessManager::getOrCreatePluginProcess(uint64_t)':
/data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp:126: error: cannot convert 'std::nullptr_t' to 'WebKit::PluginProcessProxy*' in return
make[3]: *** [.obj/release-shared/UIProcess/Plugins/PluginProcessManager.o] Error 1

changes in that file:
http://trac.webkit.org/changeset/150484/trunk/Source/WebKit2/UIProcess/Plugins/PluginProcessManager.cpp

[Csaba Osztrogonác]

It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in
Source/WTF/wtf/Compiler.h , because you use too old compiler.

But now c++11 is mandatory for WebKit2, so you probably need newer compiler.

[Balazs Kilvady]

(In reply to comment #1)
> It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in
> Source/WTF/wtf/Compiler.h , because you use too old compiler.
> 
> But now c++11 is mandatory for WebKit2, so you probably need newer compiler.

Tamk you for the info. We are working on it.

[Balazs Kilvady]

(In reply to comment #2)
> (In reply to comment #1)
> > It seems WTF_COMPILER_SUPPORTS_CXX_NULLPTR isn't defined in
> > Source/WTF/wtf/Compiler.h , because you use too old compiler.
> > 
> > But now c++11 is mandatory for WebKit2, so you probably need newer compiler.
> 
> Tamk you for the info. We are working on it.
Sorry, I wanted to write: Thank you

[Allan Sandfeld Jensen]

The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work.

[Csaba Osztrogonác]

(In reply to comment #4)
> The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work.

C++11 in WebKit2 is mandatory now... 

... but feel free to find a WebKit2 owner for this fix. :)

[Allan Sandfeld Jensen]

Created attachment 202969 [details]
Patch

[Allan Sandfeld Jensen]

(In reply to comment #5)
> (In reply to comment #4)
> > The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work.
> 
> C++11 in WebKit2 is mandatory now... 
> 
> ... but feel free to find a WebKit2 owner for this fix. :)

All of C++11 is hardly mandatory, or we would depend on unreleased compilers. There is has to be an expected subset of featuers.

[Anders Carlsson]

(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > The compiler support most of C++11, but is 'nullptr' really necessary? We can replace it with a 0, and it would work.
> > 
> > C++11 in WebKit2 is mandatory now... 
> > 
> > ... but feel free to find a WebKit2 owner for this fix. :)
> 
> All of C++11 is hardly mandatory, or we would depend on unreleased compilers. There is has to be an expected subset of featuers.

I’ve generally only used features that’s available on compilers that have been out for at least two years. That includes MSVC 2010 as well as GCC 4.6.

[Zoltan Arvai]

The bot is green again :)

[Anders Carlsson]

Comment on attachment 202969 [details]
Patch

Clearing review flag.