It's passing an empty error domain
Created attachment 202513 [details] Patch
Comment on attachment 202513 [details] Patch To be honest I don't know what's the effect of this, although the ChangeLog literally says there's no change in behavior. Are these strings picked up by someone above WebKit? It would be good to mention it in the ChangeLog.
(In reply to comment #2) > (From update of attachment 202513 [details]) > To be honest I don't know what's the effect of this, although the ChangeLog literally says there's no change in behavior. Are these strings picked up by someone above WebKit? It would be good to mention it in the ChangeLog. This is an internal commit made by Rob, I think it's pretty obvious that we were passing an empty string to the Error and now we are passing a valid error domain. I guess he meant that this doesn't affect any test, because it simply provides a valid error domain, it's up to the api consumers to use that domain or not.
Comment on attachment 202513 [details] Patch OK. I was a bit confused because I didn't get why we would put there a FIXME instead of putting whatever error domain fits better, was wondering if there was something more subtle at play here.
Comment on attachment 202513 [details] Patch Clearing flags on attachment: 202513 Committed r150585: <http://trac.webkit.org/changeset/150585>
All reviewed patches have been landed. Closing bug.