Bug 116591 - Fix issues with focus rings on search fields
Summary: Fix issues with focus rings on search fields
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-21 22:30 PDT by Simon Fraser (smfr)
Modified: 2013-05-22 12:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.13 KB, patch)
2013-05-21 22:35 PDT, Simon Fraser (smfr)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-05-21 22:30:48 PDT
Fix issues with focus rings on search fields
Comment 1 Simon Fraser (smfr) 2013-05-21 22:35:49 PDT
Created attachment 202498 [details]
Patch
Comment 2 Darin Adler 2013-05-22 07:46:04 PDT
Comment on attachment 202498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202498&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:4953
> +    // Required to fix search field focus rings <rdar://problem/13780122>.

The use of "fix" here is not clear enough. It would be better if this comment was more specific about what exactly AppKit does when we return YES here that helps us. I tried to read your comment in the change log, but I couldn’t understand it.
Comment 3 Simon Fraser (smfr) 2013-05-22 12:06:45 PDT
https://trac.webkit.org/r150530