Bug 116568 - [WK2] WebKitTestRunner always crashes on exit
Summary: [WK2] WebKitTestRunner always crashes on exit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-21 12:31 PDT by Alexey Proskuryakov
Modified: 2013-05-21 13:37 PDT (History)
3 users (show)

See Also:

Attachments
proposed fix (4.85 KB, patch)
2013-05-21 12:37 PDT, Alexey Proskuryakov 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-05-21 12:31:45 PDT 
I'm always getting a crash in WebContextSupplement::deref when WebKitTestRunner exits.

What happens here is that WebKitTestRunner destroys WTR::WebNotificationProvider when done, but WebKit doesn't know that. So when WebContext is destroyed, it calls into the deleted provider object.

void WebNotificationManagerProxy::contextDestroyed()
{
    m_provider.removeNotificationManager(this);
}

<rdar://problem/13929704>
Comment 1 Alexey Proskuryakov 2013-05-21 12:37:11 PDT 
Created attachment 202458 [details]
proposed fix
Comment 2 Alexey Proskuryakov 2013-05-21 13:37:59 PDT 
Committed <http://trac.webkit.org/r150474>.