Bug 116562 - [Win] Investigate several crashing tests
Summary: [Win] Investigate several crashing tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-21 11:03 PDT by Brent Fulgham
Modified: 2015-01-15 14:49 PST (History)
3 users (show)

See Also:


Attachments
Patch (11.47 KB, patch)
2015-01-15 14:20 PST, Brent Fulgham
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-05-21 11:03:14 PDT
Several tests are crashing.  Investigate the cause and resolve the problem.

fast/dom/Window/window-postmessage-clone-deep-array.html
fast/js/callback-function-with-handle-event.html
fast/js/large-expression.html
fast/js/string-replace-exception-crash.html
fast/text/custom-font-data-crash.html
loader/go-back-cached-main-resource.html
media/video-frame-accurate-seek.html
media/video-seek-after-end.html
media/track/track-cues-cuechange.html
svg/filters/feMorphology-crash.html
Comment 1 Brent Fulgham 2013-05-21 12:19:19 PDT
I was initially mistaken.  The actual crashes are as follows:

fast/js/callback-function-with-handle-event.html
fast/js/large-expression.html
fast/js/string-replace-exception-crash.html
fast/text/custom-font-data-crash.html
loader/go-back-cached-main-resource.html
Comment 2 Radar WebKit Bug Importer 2013-05-21 12:19:46 PDT
<rdar://problem/13951984>
Comment 3 Brent Fulgham 2013-05-21 12:32:10 PDT
Landed change to TestExpectations to avoid leaving the bots red.

<http://trac.webkit.org/changeset/150468>
Comment 4 Brent Fulgham 2013-05-21 13:53:04 PDT
Note: fast/dom/Window/window-postmessage-clone-deep-array.html also fails on several bots.  This may be a sporadic failure, but I'm excluding it for now.
Comment 5 Brent Fulgham 2013-05-24 18:25:56 PDT
fast/js/global-constructors-attributes-worker.html
svg/filters/feMorphology-crash.html
Comment 6 Brent Fulgham 2013-05-28 17:18:21 PDT
webkit.org/b/116562 fast/css/font-face-data-uri-invalid.html
Comment 7 Brent Fulgham 2013-05-29 09:18:18 PDT
media/video-beforeload-remove-source.html
Comment 8 Brent Fulgham 2014-02-17 17:49:08 PST
These were corrected by turning off the FastMalloc implementation on Windows. It did not integrate properly with header definitions for some allocators resulting in allocator/deallocator mismatch.
Comment 9 Brent Fulgham 2015-01-15 14:20:52 PST
Reopening to attach new patch.
Comment 10 Brent Fulgham 2015-01-15 14:20:53 PST
Created attachment 244713 [details]
Patch
Comment 11 WebKit Commit Bot 2015-01-15 14:22:41 PST
Attachment 244713 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/DumpRenderTree.cpp:49:  Streams are highly discouraged.  [readability/streams] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Tim Horton 2015-01-15 14:34:12 PST
Comment on attachment 244713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244713&action=review

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:523
> +        static wchar_t* layoutTestsString2 = L"\\LayoutTests\\";

You should use a better/more descriptive name than appending 2.
Comment 13 Brent Fulgham 2015-01-15 14:49:21 PST
Committed r178530: <http://trac.webkit.org/changeset/178530>