Bug 116562 – [Win] Investigate several crashing tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brent Fulgham]

Several tests are crashing.  Investigate the cause and resolve the problem.

fast/dom/Window/window-postmessage-clone-deep-array.html
fast/js/callback-function-with-handle-event.html
fast/js/large-expression.html
fast/js/string-replace-exception-crash.html
fast/text/custom-font-data-crash.html
loader/go-back-cached-main-resource.html
media/video-frame-accurate-seek.html
media/video-seek-after-end.html
media/track/track-cues-cuechange.html
svg/filters/feMorphology-crash.html

[Brent Fulgham]

I was initially mistaken.  The actual crashes are as follows:

fast/js/callback-function-with-handle-event.html
fast/js/large-expression.html
fast/js/string-replace-exception-crash.html
fast/text/custom-font-data-crash.html
loader/go-back-cached-main-resource.html

[Radar WebKit Bug Importer]

<rdar://problem/13951984>

[Brent Fulgham]

Landed change to TestExpectations to avoid leaving the bots red.

<http://trac.webkit.org/changeset/150468>

[Brent Fulgham]

Note: fast/dom/Window/window-postmessage-clone-deep-array.html also fails on several bots.  This may be a sporadic failure, but I'm excluding it for now.

[Brent Fulgham]

fast/js/global-constructors-attributes-worker.html
svg/filters/feMorphology-crash.html

[Brent Fulgham]

webkit.org/b/116562 fast/css/font-face-data-uri-invalid.html

[Brent Fulgham]

media/video-beforeload-remove-source.html

[Brent Fulgham]

These were corrected by turning off the FastMalloc implementation on Windows. It did not integrate properly with header definitions for some allocators resulting in allocator/deallocator mismatch.

[Brent Fulgham]

Reopening to attach new patch.

[Brent Fulgham]

Created attachment 244713 [details]
Patch

[WebKit Commit Bot]

Attachment 244713 [details] did not pass style-queue:


ERROR: Tools/DumpRenderTree/win/DumpRenderTree.cpp:49:  Streams are highly discouraged.  [readability/streams] [3]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 244713 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=244713&action=review

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:523
> +        static wchar_t* layoutTestsString2 = L"\\LayoutTests\\";

You should use a better/more descriptive name than appending 2.

[Brent Fulgham]

Committed r178530: <http://trac.webkit.org/changeset/178530>