The Chromium team landed a partial implementation for the TextTrackRegion. From the original bug (see https://bugs.webkit.org/show_bug.cgi?id=110511): '... defined in the "WebVTT Extension: Regions for rendering cue groups": https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/region.html' I noticed that this feature is disabled on all current WebKit ports (specifically on Apple's Windows and Mac ports). We should either activate this feature and begin testing it, or remove the code.
<rdar://problem/13949553>
(In reply to comment #0) > The Chromium team landed a partial implementation for the TextTrackRegion. From the original bug (see https://bugs.webkit.org/show_bug.cgi?id=110511): '... defined in the "WebVTT Extension: Regions for rendering cue groups": > https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/region.html' > > I noticed that this feature is disabled on all current WebKit ports (specifically on Apple's Windows and Mac ports). > > We should either activate this feature and begin testing it, or remove the code. This feature is still being actively developed in the Text CG, e.g.: https://www.w3.org/Bugs/Public/show_bug.cgi?id=22121 https://www.w3.org/Bugs/Public/show_bug.cgi?id=22114
Merge in initial Blink test cases for WebVTT: https://codereview.chromium.org/25798003
Created attachment 227069 [details] Patch
Comment on attachment 227069 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227069&action=review > LayoutTests/TestExpectations:-15 > -# pending implementation completion and feature enabling > -webkit.org/b/109570 media/track/regions-webvtt [ Skip ] Unless regions have been enabled in all builds, this will make the bots very sad.
(In reply to comment #5) > (From update of attachment 227069 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227069&action=review > > > LayoutTests/TestExpectations:-15 > > -# pending implementation completion and feature enabling > > -webkit.org/b/109570 media/track/regions-webvtt [ Skip ] > > Unless regions have been enabled in all builds, this will make the bots very sad. I'll back this out -- I mean to turn the tests on only at the end.
Committed r165815: <http://trac.webkit.org/changeset/165815>
Re-opened since this is blocked by bug 130410
Created attachment 227103 [details] Patch
The VTT test failures were caused by a mistake I made when merging the WebVTTParser code. I'm rerunning tests with this fix and will post a patch shortly.
Created attachment 227131 [details] Patch
Committed r165867: <http://trac.webkit.org/changeset/165867>