BlackBerry is doing friendly http error handling: if there is no response body for an http error it will display an error message made by the port. But for XHR request, which is not usually displaying error messages to the end user, we should reveal http error code to let the JS know what is the actual server error.
Created attachment 202440 [details] Patch
Comment on attachment 202440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202440&action=review > Source/WebCore/ChangeLog:14 > + BlackBerry is doing friendly HTTP error handling: if there is no response body > + for an HTTP error it will display an error message made by the port. But for a > + XHR request, which usually does not result in displaying error messages to the > + end user, HTTP error code should be revealed to let the JavaScript know what > + the actual server error code is. Shouldn't the difference be "main resource vs. any subresource"? There is no user visible error reporting for any subresources, not just XHR.
Comment on attachment 202440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202440&action=review >> Source/WebCore/ChangeLog:14 >> + the actual server error code is. > > Shouldn't the difference be "main resource vs. any subresource"? There is no user visible error reporting for any subresources, not just XHR. As far as I know only XHR may care about the actual status code in this case. Extends to the subresource might be a good idea but I need to evaluate the potential negative impact.
Comment on attachment 202440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202440&action=review >>> Source/WebCore/ChangeLog:14 >>> + the actual server error code is. >> >> Shouldn't the difference be "main resource vs. any subresource"? There is no user visible error reporting for any subresources, not just XHR. > > As far as I know only XHR may care about the actual status code in this case. Extends to the subresource might be a good idea but I need to evaluate the potential negative impact. Based on no-unnecessary-change, I'd like to keep current error handling for subresource `AS IS`.
Comment on attachment 202440 [details] Patch Okay.
Comment on attachment 202440 [details] Patch Sending to cq.
Comment on attachment 202440 [details] Patch Clearing flags on attachment: 202440 Committed r150759: <http://trac.webkit.org/changeset/150759>
All reviewed patches have been landed. Closing bug.