Bug 116532 - Allow session storage for third-party origins even if third-party data access is blocked.
Summary: Allow session storage for third-party origins even if third-party data access...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-21 05:48 PDT by Andy Estes
Modified: 2018-04-09 01:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.75 KB, patch)
2013-05-21 06:05 PDT, Andy Estes 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2013-05-21 05:48:04 PDT 
Allow session storage for third-party origins even if tthird-party data access is blocked.
Comment 1 Andy Estes 2013-05-21 05:50:03 PDT 
<rdar://problem/13921879>
Comment 2 Andy Estes 2013-05-21 06:05:22 PDT 
Created attachment 202420 [details]
Patch
Comment 3 Anders Carlsson 2013-05-21 15:38:25 PDT 
Comment on attachment 202420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202420&action=review

> Source/WebCore/page/SecurityOrigin.cpp:401
> +    return (m_storageBlockingPolicy == AllowAllStorage && topOrigin->m_storageBlockingPolicy == AllowAllStorage)
> +        || shouldAllowFromThirdParty == AlwaysAllowFromThirdParty
> +        || !topOrigin->isThirdParty(this);

I think this would be easier to understand as multiple early returns.
Comment 4 Andy Estes 2013-05-21 17:02:55 PDT 
Committed r150490: <http://trac.webkit.org/changeset/150490>
Comment 5 Andy Estes 2013-05-21 17:07:53 PDT 
Oops, I forgot to 'git add' the new layout test and its expected result. Fixed in <http://trac.webkit.org/changeset/150492>.