Bug 116529 - [BlackBerry] FontCache::getFontDataForCharacters() returns nullptr
Summary: [BlackBerry] FontCache::getFontDataForCharacters() returns nullptr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 111729
  Show dependency treegraph
 
Reported: 2013-05-21 03:25 PDT by Alberto Garcia
Modified: 2013-05-21 08:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2013-05-21 03:26 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-05-21 03:25:03 PDT
This cannot be converted to a PassRefPtr and breaks the build:

FontCacheBlackBerry.cpp:150:16: error: could not convert 'nullptr' from 'std::nullptr_t' to 'WTF::PassRefPtr<WebCore::SimpleFontData>'
FontCacheBlackBerry.cpp:174:16: error: could not convert 'nullptr' from 'std::nullptr_t' to 'WTF::PassRefPtr<WebCore::SimpleFontData>'

The change was introduced in r147639

http://trac.webkit.org/changeset/147639/trunk/Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp
Comment 1 Alberto Garcia 2013-05-21 03:26:14 PDT
Created attachment 202404 [details]
Patch
Comment 2 Andreas Kling 2013-05-21 08:28:01 PDT
Comment on attachment 202404 [details]
Patch

Oops, my bad! r=me
Comment 3 WebKit Commit Bot 2013-05-21 08:49:50 PDT
Comment on attachment 202404 [details]
Patch

Clearing flags on attachment: 202404

Committed r150442: <http://trac.webkit.org/changeset/150442>
Comment 4 WebKit Commit Bot 2013-05-21 08:49:51 PDT
All reviewed patches have been landed.  Closing bug.