Bug 116516 - REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
Summary: REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 116573
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-20 23:16 PDT by Ryosuke Niwa
Modified: 2013-05-21 14:27 PDT (History)
1 user (show)

See Also:

Attachments
Fixes the bug (2.10 KB, patch)
2013-05-21 00:36 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Fixes DRT (2.11 KB, patch)
2013-05-21 14:23 PDT, Ryosuke Niwa 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-05-20 23:16:29 PDT 
REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html
Comment 1 Ryosuke Niwa 2013-05-21 00:36:56 PDT 
Created attachment 202389 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2013-05-21 00:38:50 PDT 
Committed r150425: <http://trac.webkit.org/changeset/150425>
Comment 3 WebKit Commit Bot 2013-05-21 13:40:40 PDT 
Re-opened since this is blocked by bug 116573
Comment 4 Ryosuke Niwa 2013-05-21 14:23:31 PDT 
Created attachment 202470 [details]
Fixes DRT
Comment 5 Alexey Proskuryakov 2013-05-21 14:25:17 PDT 
Comment on attachment 202470 [details]
Fixes DRT

View in context: https://bugs.webkit.org/attachment.cgi?id=202470&action=review

> Tools/DumpRenderTree/mac/DumpRenderTree.mm:549
> -    [webView setDefersCallbacks:NO];
>      [webView setGrammarCheckingEnabled:YES];
> +
> +    [webView setDefersCallbacks:NO];

Why this change?
Comment 6 Ryosuke Niwa 2013-05-21 14:26:42 PDT 
Comment on attachment 202470 [details]
Fixes DRT

View in context: https://bugs.webkit.org/attachment.cgi?id=202470&action=review

>> Tools/DumpRenderTree/mac/DumpRenderTree.mm:549
>> +    [webView setDefersCallbacks:NO];
> 
> Why this change?

I matched the ordering.
Comment 7 Ryosuke Niwa 2013-05-21 14:27:34 PDT 
Committed r150479: <http://trac.webkit.org/changeset/150479>