NEW 116505
Use compositing modes instead of an intermediate buffer for `background-clip: text` 
https://bugs.webkit.org/show_bug.cgi?id=116505
Summary Use compositing modes instead of an intermediate buffer for `background-clip:...
Ryosuke Niwa
Reported 2013-05-20 19:33:08 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/b0107d990051caf8b544d2c3befc215800655b84 Currently, -webkit-background-clip: text is implemented by drawing the text content into a mask bitmap allocated in paintFillLayerExtended(). This is problematic when using impl-side painting on HiDPI devices, because the image buffer cannot be sized accurately at record time (the device scale factor & page scale are unknown). To avoid computing a mask size, this patch replaces explicit bitmap allocation with Skia saveLayer() calls. This way the actual backing bitmap allocation is deferred until playback time, when the true resolution is known. Adding a test to exercise '-webkit-background-clip: text' in non-SourceOver background compositing mode.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-09-14 14:34:22 PDT
This is still present: https://github.com/WebKit/WebKit/blob/782c4bbb354fa2b77d5747c1cd9c9a5cdb6069ec/Source/WebCore/rendering/BackgroundPainter.cpp#L300 Is this needed anymore? Thanks!
Simon Fraser (smfr)
Comment 2 2024-08-08 20:46:13 PDT
Yes, we should still do this.
Note You need to log in before you can comment on or make changes to this bug.