RESOLVED FIXED Bug 116492
Remove DriverProxy._running_drivers from webkitpy.layout_tests.port 
https://bugs.webkit.org/show_bug.cgi?id=116492
Summary Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
Ryosuke Niwa
Reported 2013-05-20 19:08:46 PDT
Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3 The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line) so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine) and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x the number of workers started). If anything, this seemed to make the tests slightly slower and probably added to memory pressure on the machine. This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change, we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that for a subsequent patch just to make things easier to follow.
Attachments
Merges the patch (3.57 KB, patch)
2013-05-20 19:10 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-05-20 19:10:17 PDT
Created attachment 202369 [details] Merges the patch
WebKit Commit Bot
Comment 2 2013-05-20 22:49:51 PDT
Comment on attachment 202369 [details] Merges the patch Clearing flags on attachment: 202369 Committed r150416: <http://trac.webkit.org/changeset/150416>
WebKit Commit Bot
Comment 3 2013-05-20 22:49:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.