Bug 116488 – Readd asserts against calling mapAbsoluteToLocalPoint during layout

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Layout and Rendering

[Ryosuke Niwa]

Consider merging https://chromium.googlesource.com/chromium/blink/+/7928f8a58d115b0672791cacdf1c93a9231ca320

I removed these assertions in r127681 for centering <dialog> in the
viewport. It was incorrect to do so: converting from absolute to local
coordinates during a renderer's layout incorrectly assumes its ancestors
have been already laid out. Now that dialog's containing block is the
initial containing block, it's no longer necessary to convert.

The assertions were originally added in r38186 and r50184.

[Ahmad Saleem]

Missing Assert from RenderBox.cpp:

https://github.com/WebKit/WebKit/blob/94a7be7787d38909554344152db793c2c361eb17/Source/WebCore/rendering/RenderBox.cpp#L2456

and also from RenderBoxModelObject.cpp:

https://github.com/WebKit/WebKit/blob/94a7be7787d38909554344152db793c2c361eb17/Source/WebCore/rendering/RenderBoxModelObject.cpp#L2666

[e-mail] - Is it needed now? Thanks!

[Ryosuke Niwa]

This is won't fix at this point.