WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
116482
Use std::lower_bound to reduce RenderQuote.o by 82k
https://bugs.webkit.org/show_bug.cgi?id=116482
Summary
Use std::lower_bound to reduce RenderQuote.o by 82k
Ryosuke Niwa
Reported
2013-05-20 18:06:26 PDT
We might want to consider merging
https://chromium.googlesource.com/chromium/blink/+/d1c61feb4585e24e5e29f9cca37aeed81e180049
Having a HashTable in RenderQuote adds tons of generated code to RenderQuote.o, and then the initialization code to fill the hash table adds even more. Instead we can use std::lower_bound and manually implement the mapping from quote language to QuotesData. This reduces libwebkit.dylib on my mac in Release from 40.52 to 40.44MB
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug