Bug 116476 - Active DOM object resumption should match reason for suspending
Summary: Active DOM object resumption should match reason for suspending
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Vicki Pfau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-20 16:46 PDT by Vicki Pfau
Modified: 2013-05-22 18:11 PDT (History)
2 users (show)

See Also:


Attachments
Patch (9.06 KB, patch)
2013-05-20 17:33 PDT, Vicki Pfau
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vicki Pfau 2013-05-20 16:46:48 PDT
We provide a reason as to why active DOM objects are suspended, but we don't check when resuming that the reason we're resuming matches the reason we suspended. This could potentially lead to cases in which we attempt to resume multiple times with the first one not matching the reason we suspended. This will lead to us potentially resuming early or resuming multiple times. We should only resume if the reason we're resuming matches the reason we suspended.
Comment 1 Vicki Pfau 2013-05-20 17:33:39 PDT
Created attachment 202334 [details]
Patch
Comment 2 Joseph Pecoraro 2013-05-20 23:20:00 PDT
Comment on attachment 202334 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202334&action=review

r=me

> Source/WebCore/ChangeLog:12
> +        No new tests, code path should not be hit currently.

Nit: The code path is hit, there just isn't a change in behavior.

> Source/WebCore/dom/ScriptExecutionContext.h:179
> +    ActiveDOMObject::ReasonForSuspension reasonForSuspendingActiveDOMObjects() { return m_reasonForSuspendingActiveDOMObjects; }

const
Comment 3 Vicki Pfau 2013-05-22 18:11:25 PDT
Committed r150560: <http://trac.webkit.org/changeset/150560>