WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 116474
check-webkit-style should not warn about use of C++11 “>>” instead of “> >"
https://bugs.webkit.org/show_bug.cgi?id=116474
Summary
check-webkit-style should not warn about use of C++11 “>>” instead of “> >"
Jessie Berlin
Reported
2013-05-20 16:12:59 PDT
Right now it spits out the following warning: Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:719: Missing spaces around >> [whitespace/operators] [3] for a line like void WebChromeClient::didAssociateFormControls(const Vector<RefPtr<WebCore::Element>>& elements) It shouldn’t, since we are using C++11 in WK2.
Attachments
Patch
(2.61 KB, patch)
2013-09-19 18:10 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(1.73 MB, patch)
2013-09-30 21:11 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2013-09-19 18:10:32 PDT
Created
attachment 212112
[details]
Patch
Sam Weinig
Comment 2
2013-09-30 21:11:40 PDT
Created
attachment 213052
[details]
Patch
Ryosuke Niwa
Comment 3
2013-09-30 21:20:39 PDT
Wrong bug?
Sam Weinig
Comment 4
2013-09-30 21:25:06 PDT
(In reply to
comment #3
)
> Wrong bug?
Yup :(.
WebKit Commit Bot
Comment 5
2013-09-30 21:56:34 PDT
Comment on
attachment 212112
[details]
Patch Clearing flags on attachment: 212112 Committed
r156694
: <
http://trac.webkit.org/changeset/156694
>
WebKit Commit Bot
Comment 6
2013-09-30 21:56:37 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug