Bug 116447 - Use '__typeof__' keyword to avoid problems when compiling in C++11 standard compliance
Summary: Use '__typeof__' keyword to avoid problems when compiling in C++11 standard c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-20 10:52 PDT by Zan Dobersek
Modified: 2013-05-20 23:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2013-05-20 11:06 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-05-20 10:52:00 PDT 
Use '__typeof__' keyword to avoid problems when compiling in C++11 standard compliance
Comment 1 Zan Dobersek 2013-05-20 11:06:50 PDT 
Created attachment 202293 [details]
Patch
Comment 2 Darin Adler 2013-05-20 11:09:03 PDT 
Comment on attachment 202293 [details]
Patch

OK, as long as it supports all the compilers we need it to.
Comment 3 Zan Dobersek 2013-05-20 12:36:54 PDT 
This should cover GCC and Clang, I'll get someone familiar with BlackBerry's qcc compiler to confirm this wouldn't break anything for them. Thanks for reviewing.
Comment 4 Jeff Rogers 2013-05-20 18:19:29 PDT 
(In reply to comment #3)
> This should cover GCC and Clang, I'll get someone familiar with BlackBerry's qcc compiler to confirm this wouldn't break anything for them. Thanks for reviewing.

This is fine for BlackBerry.
Comment 5 Zan Dobersek 2013-05-20 23:10:30 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > This should cover GCC and Clang, I'll get someone familiar with BlackBerry's qcc compiler to confirm this wouldn't break anything for them. Thanks for reviewing.
> 
> This is fine for BlackBerry.

Thanks for the input.
Comment 6 Zan Dobersek 2013-05-20 23:11:05 PDT 
Comment on attachment 202293 [details]
Patch

Clearing flags on attachment: 202293

Committed r150419: <http://trac.webkit.org/changeset/150419>
Comment 7 Zan Dobersek 2013-05-20 23:11:10 PDT 
All reviewed patches have been landed.  Closing bug.