Bug 116442 – [GTK] Support application/x-mimearchive mimetype for MHTML archives instead of message/rfc822

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Zan Dobersek]

[GTK] Support application/x-mimearchive mimetype for MHTML archives instead of message/rfc822

[Zan Dobersek]

Created attachment 202282 [details]
Patch

[WebKit Commit Bot]

Attachment 202282 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/archive/ArchiveFactory.cpp']" exit_code: 1
Source/WebCore/loader/archive/ArchiveFactory.cpp:71:  Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

(In reply to comment #2)
> Attachment 202282 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/archive/ArchiveFactory.cpp']" exit_code: 1
> Source/WebCore/loader/archive/ArchiveFactory.cpp:71:  Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]
> Total errors found: 1 in 2 files

I've kept the current approach, but filed bug #116453 to cover the layering violation.

[Martin Robinson]

Comment on attachment 202282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202282&action=review

>> Source/WebCore/loader/archive/ArchiveFactory.cpp:71
>> +#if PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(QT)
> 
> Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]

Do you know what other platform enable MHTML other than EFL/GTK/Qt? Perhaps that platform should use the new mime-type as well.

[Zan Dobersek]

Comment on attachment 202282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202282&action=review

>>> Source/WebCore/loader/archive/ArchiveFactory.cpp:71
>>> +#if PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(QT)
>> 
>> Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]
> 
> Do you know what other platform enable MHTML other than EFL/GTK/Qt? Perhaps that platform should use the new mime-type as well.

The build systems of the in-tree ports and the FeatureList.pm module show that only these three ports enable MHTML.

[Martin Robinson]

(In reply to comment #5)

> The build systems of the in-tree ports and the FeatureList.pm module show that only these three ports enable MHTML.

So perhaps this can just be simplified to #if ENABLE(MATHML) then?

[Zan Dobersek]

Ah, of course. Wasn't looking at it that way.

[Zan Dobersek]

Created attachment 202307 [details]
Patch

[Zan Dobersek]

The relevant shared-mime-info patch:
http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=5dc7a385dfde27baabbe7384e69605c48adbf1e4

[Zan Dobersek]

Comment on attachment 202307 [details]
Patch

Clearing flags on attachment: 202307

Committed r150418: <http://trac.webkit.org/changeset/150418>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.