Bug 116442 - [GTK] Support application/x-mimearchive mimetype for MHTML archives instead of message/rfc822
Summary: [GTK] Support application/x-mimearchive mimetype for MHTML archives instead o...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-20 09:39 PDT by Zan Dobersek
Modified: 2013-05-20 23:07 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2013-05-20 09:44 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2013-05-20 12:48 PDT, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-05-20 09:39:19 PDT
[GTK] Support application/x-mimearchive mimetype for MHTML archives instead of message/rfc822
Comment 1 Zan Dobersek 2013-05-20 09:44:14 PDT
Created attachment 202282 [details]
Patch
Comment 2 WebKit Commit Bot 2013-05-20 09:45:01 PDT
Attachment 202282 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/archive/ArchiveFactory.cpp']" exit_code: 1
Source/WebCore/loader/archive/ArchiveFactory.cpp:71:  Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2013-05-20 11:43:32 PDT
(In reply to comment #2)
> Attachment 202282 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/loader/archive/ArchiveFactory.cpp']" exit_code: 1
> Source/WebCore/loader/archive/ArchiveFactory.cpp:71:  Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]
> Total errors found: 1 in 2 files

I've kept the current approach, but filed bug #116453 to cover the layering violation.
Comment 4 Martin Robinson 2013-05-20 12:04:52 PDT
Comment on attachment 202282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202282&action=review

>> Source/WebCore/loader/archive/ArchiveFactory.cpp:71
>> +#if PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(QT)
> 
> Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]

Do you know what other platform enable MHTML other than EFL/GTK/Qt? Perhaps that platform should use the new mime-type as well.
Comment 5 Zan Dobersek 2013-05-20 12:34:34 PDT
Comment on attachment 202282 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202282&action=review

>>> Source/WebCore/loader/archive/ArchiveFactory.cpp:71
>>> +#if PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(QT)
>> 
>> Do not add platform specific code in WebCore outside of platform.  [build/webcore_platform_layering_violation] [5]
> 
> Do you know what other platform enable MHTML other than EFL/GTK/Qt? Perhaps that platform should use the new mime-type as well.

The build systems of the in-tree ports and the FeatureList.pm module show that only these three ports enable MHTML.
Comment 6 Martin Robinson 2013-05-20 12:36:11 PDT
(In reply to comment #5)

> The build systems of the in-tree ports and the FeatureList.pm module show that only these three ports enable MHTML.

So perhaps this can just be simplified to #if ENABLE(MATHML) then?
Comment 7 Zan Dobersek 2013-05-20 12:38:56 PDT
Ah, of course. Wasn't looking at it that way.
Comment 8 Zan Dobersek 2013-05-20 12:48:22 PDT
Created attachment 202307 [details]
Patch
Comment 9 Zan Dobersek 2013-05-20 23:03:23 PDT
The relevant shared-mime-info patch:
http://cgit.freedesktop.org/xdg/shared-mime-info/commit/?id=5dc7a385dfde27baabbe7384e69605c48adbf1e4
Comment 10 Zan Dobersek 2013-05-20 23:07:50 PDT
Comment on attachment 202307 [details]
Patch

Clearing flags on attachment: 202307

Committed r150418: <http://trac.webkit.org/changeset/150418>
Comment 11 Zan Dobersek 2013-05-20 23:07:56 PDT
All reviewed patches have been landed.  Closing bug.