Bug 116441 - [CSS Regions] Remove the offsetFromLogicalTopOfFirstPage parameter from layout functions
Summary: [CSS Regions] Remove the offsetFromLogicalTopOfFirstPage parameter from layou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 116296
  Show dependency tree / graph
 
Reported: 2013-05-20 08:52 PDT by Andrei Bucur
Modified: 2013-05-27 02:41 PDT (History)
13 users (show)

See Also:

Attachments
Patch (57.03 KB, patch)
2013-05-20 09:03 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch (68.50 KB, patch)
2013-05-21 07:38 PDT, Andrei Bucur 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (69.27 KB, patch)
2013-05-21 08:01 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Patch for landing (69.04 KB, patch)
2013-05-27 01:29 PDT, Andrei Bucur 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2013-05-20 08:52:48 PDT 
Passing around offsetFromLogicalTopOfFirstPage to the RenderBox/RenderBlock functions seems redundant and it may be bug prone (e.g. the RenderBoxRegionInfo structures are cached for a region not a (region, offset) pair). I think this parameter was added because:
- the offset values cached on layout state work only for the current block being laid out
- only RenderBlock had offsetFromLogicalTopOfFirstPage() implemented

Fix this before trying to change how ranges are computed to simplify the code.
Comment 1 Andrei Bucur 2013-05-20 09:03:14 PDT 
Created attachment 202280 [details]
Patch
Comment 2 Early Warning System Bot 2013-05-20 09:09:53 PDT 
Comment on attachment 202280 [details]
Patch

Attachment 202280 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/497639
Comment 3 Early Warning System Bot 2013-05-20 09:09:59 PDT 
Comment on attachment 202280 [details]
Patch

Attachment 202280 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/383103
Comment 4 kov's GTK+ EWS bot 2013-05-20 09:17:42 PDT 
Comment on attachment 202280 [details]
Patch

Attachment 202280 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/307331
Comment 5 Build Bot 2013-05-20 09:27:37 PDT 
Comment on attachment 202280 [details]
Patch

Attachment 202280 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/299156
Comment 6 Build Bot 2013-05-20 09:30:16 PDT 
Comment on attachment 202280 [details]
Patch

Attachment 202280 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/438431
Comment 7 EFL EWS Bot 2013-05-20 10:05:23 PDT 
Comment on attachment 202280 [details]
Patch

Attachment 202280 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/383116
Comment 8 Build Bot 2013-05-20 12:55:26 PDT 
Comment on attachment 202280 [details]
Patch

Attachment 202280 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/289376
Comment 9 EFL EWS Bot 2013-05-20 18:24:23 PDT 
Comment on attachment 202280 [details]
Patch

Attachment 202280 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/527016
Comment 10 Andrei Bucur 2013-05-21 07:38:42 PDT 
Created attachment 202427 [details]
Patch
Comment 11 Early Warning System Bot 2013-05-21 07:45:26 PDT 
Comment on attachment 202427 [details]
Patch

Attachment 202427 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/525210
Comment 12 EFL EWS Bot 2013-05-21 07:45:49 PDT 
Comment on attachment 202427 [details]
Patch

Attachment 202427 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/524230
Comment 13 Early Warning System Bot 2013-05-21 07:46:51 PDT 
Comment on attachment 202427 [details]
Patch

Attachment 202427 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/365252
Comment 14 Mihai Maerean 2013-05-21 07:54:41 PDT 
Comment on attachment 202427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202427&action=review

> Source/WebCore/rendering/RenderFlowThread.cpp:1007
> +void RenderFlowThread::popFlowThreadLayoutState()

add an assert that you have content to pop.
Comment 15 Andrei Bucur 2013-05-21 08:01:57 PDT 
Created attachment 202430 [details]
Patch
Comment 16 Dave Hyatt 2013-05-23 14:39:57 PDT 
Comment on attachment 202430 [details]
Patch

r=me. Good patch!
Comment 17 Andrei Bucur 2013-05-27 01:29:09 PDT 
Created attachment 202954 [details]
Patch for landing
Comment 18 WebKit Commit Bot 2013-05-27 02:41:33 PDT 
Comment on attachment 202954 [details]
Patch for landing

Clearing flags on attachment: 202954

Committed r150743: <http://trac.webkit.org/changeset/150743>
Comment 19 WebKit Commit Bot 2013-05-27 02:41:36 PDT 
All reviewed patches have been landed.  Closing bug.