Bug 116436 - [Mac] captions menu should behave more like a menu
Summary: [Mac] captions menu should behave more like a menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-20 05:17 PDT by Antoine Quint
Modified: 2013-05-20 09:47 PDT (History)
9 users (show)

See Also:


Attachments
Patch (19.10 KB, patch)
2013-05-20 05:31 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (19.10 KB, patch)
2013-05-20 07:51 PDT, Antoine Quint
eric.carlson: review+
graouts: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-05-20 05:17:46 PDT
The captions menu doesn't quite behave like a regular menu of this genre on the Mac. It should dismiss when clicking anywhere outside of it on the page and it should prevent the page from scrolling when attempting to scroll the menu when the menu can't scroll anymore.
Comment 1 Antoine Quint 2013-05-20 05:18:02 PDT
<rdar://problem/13900405>
Comment 2 Antoine Quint 2013-05-20 05:31:27 PDT
Created attachment 202272 [details]
Patch
Comment 3 Antoine Quint 2013-05-20 07:51:25 PDT
Created attachment 202275 [details]
Patch
Comment 4 Eric Carlson 2013-05-20 08:02:04 PDT
Comment on attachment 202275 [details]
Patch

Nice patch, thanks!
Comment 5 Antoine Quint 2013-05-20 09:47:08 PDT
https://trac.webkit.org/changeset/150371