WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116421
Remove custom binding for the Clipboard clearData function
https://bugs.webkit.org/show_bug.cgi?id=116421
Summary
Remove custom binding for the Clipboard clearData function
Darin Adler
Reported
2013-05-19 16:49:57 PDT
Remove custom binding for the Clipboard clearData function
Attachments
Patch
(7.50 KB, patch)
2013-05-19 16:52 PDT
,
Darin Adler
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Adler
Comment 1
2013-05-19 16:52:28 PDT
Created
attachment 202248
[details]
Patch
Andreas Kling
Comment 2
2013-05-19 18:03:31 PDT
Comment on
attachment 202248
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=202248&action=review
> Source/WebCore/bindings/js/JSClipboardCustom.cpp:-80 > - // FIXME: It does not match the rest of the JS bindings to throw on invalid number of arguments. > - return throwError(exec, createSyntaxError(exec, "clearData: Invalid number of arguments"));
So we will no longer throw for argumentCount() >= 2?
Andreas Kling
Comment 3
2013-05-19 18:04:17 PDT
Comment on
attachment 202248
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=202248&action=review
>> Source/WebCore/bindings/js/JSClipboardCustom.cpp:-80 >> - return throwError(exec, createSyntaxError(exec, "clearData: Invalid number of arguments")); > > So we will no longer throw for argumentCount() >= 2?
Oh wait, I see. It won't find an overload, and throw due to that. r=me
WebKit Commit Bot
Comment 4
2013-05-20 11:09:51 PDT
Comment on
attachment 202248
[details]
Patch Clearing flags on attachment: 202248 Committed
r150373
: <
http://trac.webkit.org/changeset/150373
>
WebKit Commit Bot
Comment 5
2013-05-20 11:09:54 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 6
2019-02-06 09:02:53 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug