RESOLVED FIXED 116411
Use Element instead of Node in DragState, also redo DragState struct 
https://bugs.webkit.org/show_bug.cgi?id=116411
Summary Use Element instead of Node in DragState, also redo DragState struct
Darin Adler
Reported 2013-05-19 05:11:26 PDT
Use Element instead of Node in DragState, also redo DragState struct
Attachments
Patch (32.92 KB, patch)
2013-05-19 05:52 PDT, Darin Adler 		sam: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (502.82 KB, application/zip)
2013-05-19 08:37 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-05-19 05:52:33 PDT
Created attachment 202231 [details] Patch
Build Bot
Comment 2 2013-05-19 08:37:50 PDT
Comment on attachment 202231 [details] Patch Attachment 202231 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/498543 New failing tests: editing/selection/user-drag-element-and-user-select-none.html
Build Bot
Comment 3 2013-05-19 08:37:51 PDT
Created attachment 202236 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3
Darin Adler
Comment 4 2013-05-19 13:26:13 PDT
I’ll check on the regression test failure and fix it before I land.
Darin Adler
Comment 5 2013-05-19 14:50:51 PDT
Committed r150354: <http://trac.webkit.org/changeset/150354>
Ryosuke Niwa
Comment 6 2013-05-20 15:58:36 PDT
(In reply to comment #2) > (From update of attachment 202231 [details]) > Attachment 202231 [details] did not pass mac-wk2-ews (mac-wk2): > Output: http://webkit-queues.appspot.com/results/498543 > > New failing tests: > editing/selection/user-drag-element-and-user-select-none.html This patch broke editing/selection/user-drag-element-and-user-select-none.html: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r150354%20(9004)/results.html
Note You need to log in before you can comment on or make changes to this bug.