Hoist several chunks of code at the top of RenderLayer::paintLayerContents() onto new functions
Created attachment 202224 [details] Patch
Attachment 202224 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h']" exit_code: 1 Source/WebCore/ChangeLog:12: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/WebCore/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Source/WebCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 202224 [details] Patch Attachment 202224 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/494832
Comment on attachment 202224 [details] Patch Attachment 202224 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/493800
Comment on attachment 202224 [details] Patch Attachment 202224 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/494833
Comment on attachment 202224 [details] Patch Attachment 202224 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/497538
Comment on attachment 202224 [details] Patch Attachment 202224 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/493804
Comment on attachment 202224 [details] Patch Attachment 202224 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/486941
Created attachment 202225 [details] Patch
Comment on attachment 202225 [details] Patch Attachment 202225 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/493810
Comment on attachment 202225 [details] Patch Attachment 202225 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/490871
Created attachment 202226 [details] Patch
Comment on attachment 202226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202226&action=review r=me. > Source/WebCore/rendering/RenderLayer.cpp:3691 > +bool RenderLayer::setupFontSubpixelQuantization(GraphicsContext* context, bool &didQuantizeFonts) & placement. > Source/WebCore/rendering/RenderLayer.cpp:3725 > + if (!style) > + return false; This could be an assertion instead; 'style' won't be null if the renderer has a clip path. > Source/WebCore/rendering/RenderLayer.h:939 > + bool setupFontSubpixelQuantization(GraphicsContext*, bool &didQuantizeFonts); & placement.
http://trac.webkit.org/changeset/150349