Bug 116406 – Hoist several chunks of code at the top of RenderLayer::paintLayerContents() onto new functions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Hoist several chunks of code at the top of RenderLayer::paintLayerContents() onto new functions

[Simon Fraser (smfr)]

Created attachment 202224 [details]
Patch

[WebKit Commit Bot]

Attachment 202224 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/rendering/FilterEffectRenderer.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayer.h']" exit_code: 1
Source/WebCore/ChangeLog:12:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:14:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/WebCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 202224 [details]
Patch

Attachment 202224 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/494832

[Early Warning System Bot]

Comment on attachment 202224 [details]
Patch

Attachment 202224 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/493800

[EFL EWS Bot]

Comment on attachment 202224 [details]
Patch

Attachment 202224 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/494833

[Early Warning System Bot]

Comment on attachment 202224 [details]
Patch

Attachment 202224 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/497538

[kov's GTK+ EWS bot]

Comment on attachment 202224 [details]
Patch

Attachment 202224 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/493804

[Build Bot]

Comment on attachment 202224 [details]
Patch

Attachment 202224 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/486941

[Simon Fraser (smfr)]

Created attachment 202225 [details]
Patch

[Early Warning System Bot]

Comment on attachment 202225 [details]
Patch

Attachment 202225 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/493810

[Early Warning System Bot]

Comment on attachment 202225 [details]
Patch

Attachment 202225 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/490871

[Simon Fraser (smfr)]

Created attachment 202226 [details]
Patch

[Andreas Kling]

Comment on attachment 202226 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202226&action=review

r=me.

> Source/WebCore/rendering/RenderLayer.cpp:3691
> +bool RenderLayer::setupFontSubpixelQuantization(GraphicsContext* context, bool &didQuantizeFonts)

& placement.

> Source/WebCore/rendering/RenderLayer.cpp:3725
> +    if (!style)
> +        return false;

This could be an assertion instead; 'style' won't be null if the renderer has a clip path.

> Source/WebCore/rendering/RenderLayer.h:939
> +    bool setupFontSubpixelQuantization(GraphicsContext*, bool &didQuantizeFonts);

& placement.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/150349