WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116397
Refactor RenderStyle::diff()
https://bugs.webkit.org/show_bug.cgi?id=116397
Summary
Refactor RenderStyle::diff()
Simon Fraser (smfr)
Reported
2013-05-18 13:32:13 PDT
RenderStyle::diff() is tricky for two reasons. First, there's nothing to enforce the requirement that "more work" diffs have to be detected before "less work" diffs (i.e. we have to always check for changes that result in StyleDifferenceLayout before changes that result in StyleDifferenceRepaint). Secondly, in some cases, even when we return, say, StyleDifferenceLayoutPositionedMovementOnly or StyleDifferenceRecompositeLayer, we also need to check for changes that require repaint, and that's not possible now.
Attachments
Patch
(26.88 KB, patch)
2013-05-18 14:24 PDT
,
Simon Fraser (smfr)
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2013-05-18 14:24:49 PDT
Created
attachment 202217
[details]
Patch
Andreas Kling
Comment 2
2013-05-18 18:11:28 PDT
Comment on
attachment 202217
[details]
Patch r=me, this is great.
Simon Fraser (smfr)
Comment 3
2013-05-19 19:27:13 PDT
http://trac.webkit.org/changeset/150348
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug