Bug 116390 – [WK2] Regression(r150305): broke build if INDEXED_DATABASE is enabled

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit2

[Chris Dumez]

<http://trac.webkit.org/changeset/150305> broke the WebKit2 build if INDEXED_DATABASE is enabled at compile time:
[ 84%] [ 84%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebPage/WebPageGroupProxy.cpp.o
Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebPage/WebUndoStep.cpp.o
[ 84%] Building CXX object Source/WebKit2/CMakeFiles/ewebkit2.dir/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp.o
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp: In constructor 'WebKit::WebPageGroupProxy::WebPageGroupProxy(const WebKit::WebPageGroupData&)':
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:66:84: error: 'class WebKit::WebKeyValueStorageManager' has no member named 'indexedDBDatabaseDirectory'
In file included from /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:29:0:
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebProcess.h: In member function 'T* WebKit::WebProcess::supplement() [with T = WebKit::WebKeyValueStorageManager]':
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:65:116:   instantiated from here
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebProcess.h:90:70: error: invalid static_cast from type 'WTF::HashMap<const char*, WTF::OwnPtr<WebKit::WebProcessSupplement>, WTF::PtrHash<const char*> >::MappedPeekType {aka WebKit::WebProcessSupplement*}' to type 'WebKit::WebKeyValueStorageManager*'
/mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/WebKit2/WebProcess/WebProcess.h:91:5: error: control reaches end of non-void function [-Werror=return-type]
cc1plus: all warnings being treated as errors

[Chris Dumez]

I temporarily disabled INDEXED_DATABASE at compile-time for EFL to quickly fix the build and put our bots back up <http://trac.webkit.org/changeset/150335>.

We need to reenable this as soon as the build issue is addressed.

[Chris Dumez]

Created attachment 202199 [details]
Patch

Andersca, is it the proper way to fix it or is more work involved?

[Zan Dobersek]

Comment on attachment 202199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202199&action=review

> Source/WebKit2/WebProcess/WebPage/WebPageGroupProxy.cpp:-67
> -#endif

Removing this fixes the build failures, but it also stops setting the path for the IDB database. I don't think that's quite OK.

[Zan Dobersek]

*** This bug has been marked as a duplicate of bug 116389 ***

[Zan Dobersek]

I (accidentally) marked this bug as a dupe of bug #116389, but feel free to switch the duplicate resolution as you please. My main interest is still to get the build failures resolved ASAP. Sorry for the noise.

[Chris Dumez]

(In reply to comment #5)
> I (accidentally) marked this bug as a dupe of bug #116389, but feel free to switch the duplicate resolution as you please. My main interest is still to get the build failures resolved ASAP. Sorry for the noise.

Sure, no problem. Sorry I failed to notice someone had already fixed a bug.
I can reenable INDEXED_DATABASE on EFL in a separate patch later on.