Handles the 'const char*' parameter in right way and enable the unit test for this API.
Created attachment 202193 [details] Patch
Comment on attachment 202193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202193&action=review Looks good. r=me with a few nit fixes. > Source/WebKit2/ChangeLog:8 > + Refactor the API to handle 'const char*' paramerter in right way and "parameter" > Source/WebKit2/UIProcess/API/efl/EwkView.h:139 > + const char* customTextEncodingName() {return m_customEncoding; } Missing space after '{'. Why isn't the getter const anymore?
Comment on attachment 202193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202193&action=review >> Source/WebKit2/ChangeLog:8 >> + Refactor the API to handle 'const char*' paramerter in right way and > > "parameter" I will fix. >> Source/WebKit2/UIProcess/API/efl/EwkView.h:139 >> + const char* customTextEncodingName() {return m_customEncoding; } > > Missing space after '{'. Why isn't the getter const anymore? Opps, my bad. This is my first patch with Sublime Text 2 but it seems to be familiar with this more. :)
Created attachment 202194 [details] Patch
Comment on attachment 202194 [details] Patch Clearing flags on attachment: 202194 Committed r150332: <http://trac.webkit.org/changeset/150332>
All reviewed patches have been landed. Closing bug.