Bug 116368 - Only allow 1 WebProcess to hold a PageCache
Summary: Only allow 1 WebProcess to hold a PageCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-17 17:35 PDT by Gavin Barraclough
Modified: 2013-05-17 18:13 PDT (History)
1 user (show)

See Also:

Attachments
Fix (10.16 KB, patch)
2013-05-17 17:43 PDT, Gavin Barraclough 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-05-17 17:35:41 PDT 
Currently if we have 20 web processes, each with 3 entries in the page cache, the cache can effectively grow to 60 entries (instead of 3).  Stop this.
Comment 1 Gavin Barraclough 2013-05-17 17:43:10 PDT 
Created attachment 202175 [details]
Fix
Comment 2 Geoffrey Garen 2013-05-17 17:53:12 PDT 
Comment on attachment 202175 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=202175&action=review

r=me

> Source/WebKit2/UIProcess/WebContext.cpp:465
> +void WebContext::processDidSaveToPageCache(WebProcessProxy* process)

How about "processDidCachePage"? -- My first reading thought that the process had been saved to some sort of cache.
Comment 3 Geoffrey Garen 2013-05-17 17:53:29 PDT 
(and Anders)
Comment 4 Gavin Barraclough 2013-05-17 18:13:24 PDT 
Fixed in r150314.