RESOLVED FIXED 116338
[Windows] Don't use pdevenv when building with VS2010 
https://bugs.webkit.org/show_bug.cgi?id=116338
Summary [Windows] Don't use pdevenv when building with VS2010
Brent Fulgham
Reported 2013-05-17 11:58:22 PDT
Visual Studio 2005 did not provide a mode for running the build across multiple cores. Consequently, a manual load-splitting system (pdevenv) was created (see <trac.webkit.org/changeset/23775>) to spread the build across available hardware. Visual Studio 2010 and newer now support the "/MP" flag, which does this for us without requiring Perl scripts or firing off bash shells to do the work. The new VS2010 project files already have the "/MP" flag turned on. So the only change needed is for our build scripts to avoid using pdevenv, since this would actually reduce performance compared to the native parallelization feature.
Attachments
Patch (1.70 KB, patch)
2013-05-17 12:00 PDT, Brent Fulgham 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2013-05-17 12:00:20 PDT
Created attachment 202132 [details] Patch
Adam Roben (:aroben)
Comment 2 2013-05-17 12:02:15 PDT
Comment on attachment 202132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=202132&action=review r=me! > Tools/ChangeLog:11 > + * Scripts/webkitdirs.pm: > + (setupCygwinEnv): Check if we are using VS2005, and only use > + the 'pdevenv' hack if we are. Otherwise, just build with > + our standard project. Might be worth mentioning somewhere in here that the VS2010 build is already compiling files in parallel.
Brent Fulgham
Comment 3 2013-05-17 12:06:13 PDT
Committed r150281: <http://trac.webkit.org/changeset/150281>
Note You need to log in before you can comment on or make changes to this bug.