Bug 116324 - Make kit(Frame*) more robust
Summary: Make kit(Frame*) more robust
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
: 116255 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-05-17 09:52 PDT by Anders Carlsson
Modified: 2013-05-17 12:21 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2013-05-17 09:54 PDT, Anders Carlsson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-17 09:52:34 PDT 
Make kit(Frame*) more robust
Comment 1 Anders Carlsson 2013-05-17 09:54:17 PDT 
Created attachment 202104 [details]
Patch
Comment 2 Darin Adler 2013-05-17 09:55:57 PDT 
Comment on attachment 202104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202104&action=review

> Source/WebKit/mac/WebView/WebFrame.mm:234
> +    FrameLoaderClient* frameLoaderClient = frame->loader()->client();
> +    if (frameLoaderClient->isEmptyFrameLoaderClient())
> +        return nil;

Man that really stinks. I wondered why you were doing this refactoring.

I would have named the local variable just client.
Comment 3 Anders Carlsson 2013-05-17 09:58:35 PDT 
Committed r150269: <http://trac.webkit.org/changeset/150269>
Comment 4 Brady Eidson 2013-05-17 12:21:41 PDT 
*** Bug 116255 has been marked as a duplicate of this bug. ***