Bug 116313 - Fix code that expects Page::chrome() to return a pointer
Summary: Fix code that expects Page::chrome() to return a pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-17 07:02 PDT by Alberto Garcia
Modified: 2013-05-17 09:06 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.70 KB, patch)
2013-05-17 07:06 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff
Patch (3.55 KB, patch)
2013-05-17 07:50 PDT, Alberto Garcia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alberto Garcia 2013-05-17 07:02:14 PDT
After r150214, (bug 116185) Page::chrome() now returns a reference, but not all code was adapted to handle this.

In particular this breaks the GTK+ debug builds.
Comment 1 Alberto Garcia 2013-05-17 07:06:38 PDT
Created attachment 202080 [details]
Patch
Comment 2 Alberto Garcia 2013-05-17 07:50:47 PDT
Created attachment 202087 [details]
Patch
Comment 3 Alberto Garcia 2013-05-17 07:51:49 PDT
I noticed that Gustavo fixed the GTK+ part in r150256.

I've just uploaded an updated patch without that file.
Comment 4 WebKit Commit Bot 2013-05-17 09:06:36 PDT
Comment on attachment 202087 [details]
Patch

Clearing flags on attachment: 202087

Committed r150263: <http://trac.webkit.org/changeset/150263>
Comment 5 WebKit Commit Bot 2013-05-17 09:06:39 PDT
All reviewed patches have been landed.  Closing bug.