Bug 116310 – [CSSRegions] Constrain auto-height region computation in a different way

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihnea Ovidenie]

After https://bugs.webkit.org/show_bug.cgi?id=74132, the region is a render block. We can use RenderBox::constrainContentBoxLogicalHeightByMinMax instead of RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight.

[Mihnea Ovidenie]

Created attachment 202077 [details]
Patch

[Alexandru Chiculita]

Comment on attachment 202077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review

Looks good. Please, add a separate bug to track the other issue.

> Source/WebCore/ChangeLog:10
> +        Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children.

We will need to add a test for regions with "box-sizing: border-box" and "height: auto". Looks like both the previous and the new functions subtract the padding out of your height.

[Mihnea Ovidenie]

(In reply to comment #2)
> (From update of attachment 202077 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review
> 
> Looks good. Please, add a separate bug to track the other issue.
> 
> > Source/WebCore/ChangeLog:10
> > +        Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children.
> 
> We will need to add a test for regions with "box-sizing: border-box" and "height: auto". Looks like both the previous and the new functions subtract the padding out of your height.

Added bug: https://bugs.webkit.org/show_bug.cgi?id=116518 to track this issue.

[Mihnea Ovidenie]

Created attachment 202387 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 202387 [details]:

media/track/track-remove-crash.html bug 115892 (author: [e-mail])
svg/batik/text/textFeatures.svg bug 116326 (authors: [e-mail] and [e-mail])
svg/batik/text/textLength.svg bug 116329 (authors: [e-mail] and [e-mail])
svg/batik/text/textEffect3.svg bug 116521 (authors: [e-mail] and [e-mail])
compositing/overflow/overflow-compositing-descendant.html bug 116485 (authors: [e-mail], [e-mail], and [e-mail])
editing/inserting/typing-at-end-of-line.html bug 116486 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 202387 [details]
Patch for landing

Clearing flags on attachment: 202387

Committed r150427: <http://trac.webkit.org/changeset/150427>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.