Bug 116299 - [CSS Regions] Extend the RenderRegionRange class to include overflow information + apply the layout overflow
Summary: [CSS Regions] Extend the RenderRegionRange class to include overflow informat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrei Bucur
URL:
Keywords: AdobeTracked
Depends on:
Blocks: 120604 116295
  Show dependency treegraph
 
Reported: 2013-05-17 03:14 PDT by Andrei Bucur
Modified: 2013-09-04 01:26 PDT (History)
15 users (show)

See Also:


Attachments
WIP (22.26 KB, patch)
2013-08-28 06:59 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
WIP v2 (29.73 KB, patch)
2013-08-30 09:13 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch (50.54 KB, patch)
2013-09-02 07:23 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch (50.76 KB, patch)
2013-09-03 02:44 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Patch (51.51 KB, patch)
2013-09-03 04:55 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (475.25 KB, application/zip)
2013-09-03 05:49 PDT, Build Bot
no flags Details
Patch for landing (54.68 KB, patch)
2013-09-03 08:18 PDT, Andrei Bucur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Bucur 2013-05-17 03:14:22 PDT
A box has attached region range information only for the border box. When propagating overflow in regions it's necessary to extend the overflow region range of the boxes to contain the overflow region range of the children. For example, a block extending over two regions that has a child in the third region as overflow needs to hold the box information for it as well (in case there's a relative transform, the overflow fragment in the third region needs to be offseted as well).
Comment 1 Andrei Bucur 2013-05-27 01:41:01 PDT
For now this won't be required because we'll just clamp all the box ranges to their containing block ranges.
Comment 2 Andrei Bucur 2013-08-28 06:59:38 PDT
Created attachment 209878 [details]
WIP
Comment 3 Build Bot 2013-08-28 08:51:42 PDT
Comment on attachment 209878 [details]
WIP

Attachment 209878 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1623276
Comment 4 Andrei Bucur 2013-08-30 09:13:37 PDT
Created attachment 210118 [details]
WIP v2
Comment 5 Dave Hyatt 2013-08-30 09:57:34 PDT
Comment on attachment 210118 [details]
WIP v2

r=me
Comment 6 Dave Hyatt 2013-08-30 09:58:19 PDT
We might want to consider making m_overflow private so that subclasses can't make the mistake of calling m_overflow.clear(). Depends on if they need to access the overflow ever right now.
Comment 7 Build Bot 2013-08-30 13:42:14 PDT
Comment on attachment 210118 [details]
WIP v2

Attachment 210118 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1627886
Comment 8 Andrei Bucur 2013-09-02 07:23:42 PDT
Created attachment 210283 [details]
Patch
Comment 9 Andrei Bucur 2013-09-02 07:56:57 PDT
(In reply to comment #6)
> We might want to consider making m_overflow private so that subclasses can't make the mistake of calling m_overflow.clear(). Depends on if they need to access the overflow ever right now.

RenderBox::m_overflow is used in a couple of places in RenderBlock. I'll make a new bug to see if I can make it private. Is that ok with you so I don't create noise in this patch?
Comment 10 Build Bot 2013-09-02 09:03:48 PDT
Comment on attachment 210283 [details]
Patch

Attachment 210283 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1659987
Comment 11 Andrei Bucur 2013-09-03 02:44:28 PDT
Created attachment 210341 [details]
Patch
Comment 12 Early Warning System Bot 2013-09-03 02:50:35 PDT
Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1693195
Comment 13 Early Warning System Bot 2013-09-03 02:52:15 PDT
Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1687279
Comment 14 EFL EWS Bot 2013-09-03 02:55:02 PDT
Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1688249
Comment 15 EFL EWS Bot 2013-09-03 02:59:47 PDT
Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1693197
Comment 16 Build Bot 2013-09-03 03:12:48 PDT
Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1688254
Comment 17 kov's GTK+ EWS bot 2013-09-03 03:25:34 PDT
Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1690206
Comment 18 Build Bot 2013-09-03 03:28:37 PDT
Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1684287
Comment 19 Andrei Bucur 2013-09-03 04:55:57 PDT
Created attachment 210352 [details]
Patch
Comment 20 Build Bot 2013-09-03 05:49:44 PDT
Comment on attachment 210352 [details]
Patch

Attachment 210352 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1684317

New failing tests:
fast/regions/element-in-named-flow-fixed-from-absolute.html
fast/regions/element-in-named-flow-absolute-from-fixed.html
fast/regions/element-outflow-static-from-inflow-fixed.html
fast/regions/element-inflow-fixed-from-outflow-static.html
Comment 21 Build Bot 2013-09-03 05:49:48 PDT
Created attachment 210361 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 22 Andrei Bucur 2013-09-03 08:18:42 PDT
Created attachment 210375 [details]
Patch for landing
Comment 23 WebKit Commit Bot 2013-09-04 01:26:53 PDT
Comment on attachment 210375 [details]
Patch for landing

Clearing flags on attachment: 210375

Committed r155026: <http://trac.webkit.org/changeset/155026>
Comment 24 WebKit Commit Bot 2013-09-04 01:26:57 PDT
All reviewed patches have been landed.  Closing bug.