Bug 116299 – [CSS Regions] Extend the RenderRegionRange class to include overflow information + apply the layout overflow

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Andrei Bucur]

A box has attached region range information only for the border box. When propagating overflow in regions it's necessary to extend the overflow region range of the boxes to contain the overflow region range of the children. For example, a block extending over two regions that has a child in the third region as overflow needs to hold the box information for it as well (in case there's a relative transform, the overflow fragment in the third region needs to be offseted as well).

[Andrei Bucur]

For now this won't be required because we'll just clamp all the box ranges to their containing block ranges.

[Andrei Bucur]

Created attachment 209878 [details]
WIP

[Build Bot]

Comment on attachment 209878 [details]
WIP

Attachment 209878 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1623276

[Andrei Bucur]

Created attachment 210118 [details]
WIP v2

[Dave Hyatt]

Comment on attachment 210118 [details]
WIP v2

r=me

[Dave Hyatt]

We might want to consider making m_overflow private so that subclasses can't make the mistake of calling m_overflow.clear(). Depends on if they need to access the overflow ever right now.

[Build Bot]

Comment on attachment 210118 [details]
WIP v2

Attachment 210118 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1627886

[Andrei Bucur]

Created attachment 210283 [details]
Patch

[Andrei Bucur]

(In reply to comment #6)
> We might want to consider making m_overflow private so that subclasses can't make the mistake of calling m_overflow.clear(). Depends on if they need to access the overflow ever right now.

RenderBox::m_overflow is used in a couple of places in RenderBlock. I'll make a new bug to see if I can make it private. Is that ok with you so I don't create noise in this patch?

[Build Bot]

Comment on attachment 210283 [details]
Patch

Attachment 210283 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1659987

[Andrei Bucur]

Created attachment 210341 [details]
Patch

[Early Warning System Bot]

Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1693195

[Early Warning System Bot]

Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1687279

[EFL EWS Bot]

Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1688249

[EFL EWS Bot]

Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1693197

[Build Bot]

Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1688254

[kov's GTK+ EWS bot]

Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1690206

[Build Bot]

Comment on attachment 210341 [details]
Patch

Attachment 210341 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1684287

[Andrei Bucur]

Created attachment 210352 [details]
Patch

[Build Bot]

Comment on attachment 210352 [details]
Patch

Attachment 210352 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1684317

New failing tests:
fast/regions/element-in-named-flow-fixed-from-absolute.html
fast/regions/element-in-named-flow-absolute-from-fixed.html
fast/regions/element-outflow-static-from-inflow-fixed.html
fast/regions/element-inflow-fixed-from-outflow-static.html

[Build Bot]

Created attachment 210361 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

[Andrei Bucur]

Created attachment 210375 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 210375 [details]
Patch for landing

Clearing flags on attachment: 210375

Committed r155026: <http://trac.webkit.org/changeset/155026>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.