RESOLVED FIXED 116297
[Qt-WK2]Build fix for Qt-WK2 after r150242 to initialize the newly added fields: willLoadURLRequest, willLoadDataRequest 
https://bugs.webkit.org/show_bug.cgi?id=116297
Summary [Qt-WK2]Build fix for Qt-WK2 after r150242 to initialize the newly added fiel...
Vivek Galatage
Reported 2013-05-17 02:36:24 PDT
[Qt-WK2]Build fix for Qt-WK2 after r150242 to initialize the newly added fields: willLoadURLRequest, willLoadDataRequest
Attachments
Patch (1.55 KB, patch)
2013-05-17 02:37 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2013-05-17 02:37:38 PDT
Created attachment 202054 [details] Patch
Noam Rosenthal
Comment 2 2013-05-17 02:48:59 PDT
Comment on attachment 202054 [details] Patch Maybe it will be better to avoid such build breaks by initializing those with memset and populating only the necessary parts?
WebKit Commit Bot
Comment 3 2013-05-17 03:11:31 PDT
Comment on attachment 202054 [details] Patch Rejecting attachment 202054 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 202054, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: /git.webkit.org/WebKit 7f3c3b2..b10ea74 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 150244 = 7f3c3b2c96940b3087ace7335517e295213b3f60 r150245 = b10ea741319d6842f4dc2f4bd005bbd2cd4b280d Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/486368
Csaba Osztrogonác
Comment 4 2013-05-17 03:12:30 PDT
It is already fixed by Zoltán - https://trac.webkit.org/changeset/150245
Csaba Osztrogonác
Comment 5 2013-05-17 03:14:16 PDT
To avoid duplicated work, I suggest you should add comment in the original bug report if you started work on a buildfix next time.
Zoltan Arvai
Comment 6 2013-05-17 03:16:20 PDT
I just read the message on #qtwebkit. Sorry for the duplicate work.
Note You need to log in before you can comment on or make changes to this bug.