Bug 116293 - media/video-seek-after-end.html is flaky
Summary: media/video-seek-after-end.html is flaky
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-17 00:02 PDT by Ryosuke Niwa
Modified: 2014-05-22 08:17 PDT (History)
15 users (show)

See Also:

Attachments
Patch (3.90 KB, patch)
2014-04-28 16:33 PDT, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (464.31 KB, application/zip)
2014-04-28 17:36 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (490.89 KB, application/zip)
2014-04-28 17:54 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (462.89 KB, application/zip)
2014-04-28 18:31 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (497.34 KB, application/zip)
2014-04-28 18:55 PDT, Build Bot 		no flags Details
Patch (4.47 KB, patch)
2014-04-29 12:02 PDT, Balazs Kelemen 		kbalazs: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Philippe Normand 2013-05-17 00:07:59 PDT 
Adding test author.
Comment 2 Ryosuke Niwa 2013-05-17 00:08:53 PDT 
Added a test expectation in http://trac.webkit.org/changeset/150244.
Comment 3 Balazs Kelemen 2013-05-17 01:58:21 PDT 
Thanks for handling it. Will look into the problem (at some point).
Comment 4 Alexey Proskuryakov 2013-09-20 09:47:16 PDT 
Any update on this?
Comment 5 Balazs Kelemen 2014-04-28 16:33:54 PDT 
Created attachment 230335 [details]
Patch
Comment 6 Build Bot 2014-04-28 17:36:06 PDT 
Comment on attachment 230335 [details]
Patch

Attachment 230335 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5110776352210944

New failing tests:
media/video-seek-after-end.html
Comment 7 Build Bot 2014-04-28 17:36:10 PDT 
Created attachment 230341 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2014-04-28 17:54:14 PDT 
Comment on attachment 230335 [details]
Patch

Attachment 230335 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5627717810651136

New failing tests:
media/video-seek-after-end.html
Comment 9 Build Bot 2014-04-28 17:54:23 PDT 
Created attachment 230344 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2014-04-28 18:31:47 PDT 
Comment on attachment 230335 [details]
Patch

Attachment 230335 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5467203608510464

New failing tests:
media/video-seek-after-end.html
Comment 11 Build Bot 2014-04-28 18:31:55 PDT 
Created attachment 230346 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 12 Build Bot 2014-04-28 18:55:09 PDT 
Comment on attachment 230335 [details]
Patch

Attachment 230335 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5178906613121024

New failing tests:
media/video-seek-after-end.html
Comment 13 Build Bot 2014-04-28 18:55:16 PDT 
Created attachment 230348 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 14 Balazs Kelemen 2014-04-29 12:02:00 PDT 
Created attachment 230396 [details]
Patch
Comment 15 Balazs Kelemen 2014-04-29 12:02:58 PDT 
Better if I change the expectation as well, let's try this again.
Comment 16 Balazs Kelemen 2014-05-01 08:43:20 PDT 
Greenness, happiness. Please review.
Comment 17 Csaba Osztrogonác 2014-05-21 22:19:00 PDT 
(In reply to comment #16)
> Greenness, happiness. Please review.

Will it fix this kind of failures? 

--- /Volumes/Data/slave/mavericks-debug-tests-wk1/build/layout-test-results/media/video-seek-after-end-expected.txt
+++ /Volumes/Data/slave/mavericks-debug-tests-wk1/build/layout-test-results/media/video-seek-after-end-actual.txt
@@ -2,9 +2,6 @@
 
 
 EVENT(playing)
-EVENT(ended)
-EVENT(seeked)
-EVENT(playing)
-EXPECTED (video.currentTime.toFixed(2) == '3') OK
+FAIL: timeout FAIL
 END OF TEST
Comment 18 Balazs Kelemen 2014-05-22 00:23:52 PDT 
(In reply to comment #17)
> (In reply to comment #16)
> > Greenness, happiness. Please review.
> 
> Will it fix this kind of failures? 
> 
> --- /Volumes/Data/slave/mavericks-debug-tests-wk1/build/layout-test-results/media/video-seek-after-end-expected.txt
> +++ /Volumes/Data/slave/mavericks-debug-tests-wk1/build/layout-test-results/media/video-seek-after-end-actual.txt
> @@ -2,9 +2,6 @@
> 
> 
>  EVENT(playing)
> -EVENT(ended)
> -EVENT(seeked)
> -EVENT(playing)
> -EXPECTED (video.currentTime.toFixed(2) == '3') OK
> +FAIL: timeout FAIL
>  END OF TEST

No, but where do you see this? This should never happen if the bot is functioning normally.
Comment 19 Balazs Kelemen 2014-05-22 08:16:58 PDT 
(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > Greenness, happiness. Please review.
> > 
> > Will it fix this kind of failures? 
> > 
> > --- /Volumes/Data/slave/mavericks-debug-tests-wk1/build/layout-test-results/media/video-seek-after-end-expected.txt
> > +++ /Volumes/Data/slave/mavericks-debug-tests-wk1/build/layout-test-results/media/video-seek-after-end-actual.txt
> > @@ -2,9 +2,6 @@
> > 
> > 
> >  EVENT(playing)
> > -EVENT(ended)
> > -EVENT(seeked)
> > -EVENT(playing)
> > -EXPECTED (video.currentTime.toFixed(2) == '3') OK
> > +FAIL: timeout FAIL
> >  END OF TEST
> 
> No, but where do you see this? This should never happen if the bot is functioning normally.

Ah, ok, I found it. Not sure what to do, I have no clue how can this happen, or how can any media test not fail if that can happen. I need to think about it.
Comment 20 Balazs Kelemen 2014-05-22 08:17:26 PDT 
Comment on attachment 230396 [details]
Patch

This is not ready yet to fix all issues seen on bots.