Bug 116291 - Minor String fixes in CSS
Summary: Minor String fixes in CSS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 22:42 PDT by Benjamin Poulain
Modified: 2013-05-20 22:57 PDT (History)
9 users (show)

See Also:

Attachments
Patch (21.12 KB, patch)
2013-05-16 22:48 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (21.15 KB, patch)
2013-05-20 13:27 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-05-16 22:42:31 PDT 
Minor String fixes in CSS
Comment 1 Benjamin Poulain 2013-05-16 22:48:27 PDT 
Created attachment 202046 [details]
Patch
Comment 2 Early Warning System Bot 2013-05-16 22:54:05 PDT 
Comment on attachment 202046 [details]
Patch

Attachment 202046 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/481795
Comment 3 Build Bot 2013-05-16 23:13:33 PDT 
Comment on attachment 202046 [details]
Patch

Attachment 202046 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/494163
Comment 4 Early Warning System Bot 2013-05-17 04:01:59 PDT 
Comment on attachment 202046 [details]
Patch

Attachment 202046 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/483672
Comment 5 Darin Adler 2013-05-17 08:59:00 PDT 
Comment on attachment 202046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202046&action=review

r=me if you fix the thing I noticed, and get Qt and Windows building

> Source/WebCore/css/CSSPropertySourceData.cpp:92
> -    DEFINE_STATIC_LOCAL(String, emptyValue, (ASCIILiteral("e")));
> -    DEFINE_STATIC_LOCAL(String, importantSuffix, (ASCIILiteral(" !important")));
> -    if (!name && value == emptyValue)
> +    if (!name && value[0] == 'e')

This changes behavior. It now only checks that the first letter is e, rather than checking that the entire string is "e". Is that OK? Is there test coverage?
Comment 6 Benjamin Poulain 2013-05-20 13:27:30 PDT 
Created attachment 202314 [details]
Patch
Comment 7 Benjamin Poulain 2013-05-20 22:57:20 PDT 
Comment on attachment 202314 [details]
Patch

Clearing flags on attachment: 202314

Committed r150417: <http://trac.webkit.org/changeset/150417>
Comment 8 Benjamin Poulain 2013-05-20 22:57:24 PDT 
All reviewed patches have been landed.  Closing bug.