Bug 116290 - Web Inspector: Allow "//# sourceMappingURL" syntax alongside "//@"
Summary: Web Inspector: Allow "//# sourceMappingURL" syntax alongside "//@"
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on:
Reported: 2013-05-16 22:21 PDT by Joseph Pecoraro
Modified: 2013-05-17 05:30 PDT (History)
4 users (show)

See Also:

[PATCH] Proposed Fix (6.63 KB, patch)
2013-05-16 22:53 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-05-16 22:21:23 PDT
Deprecating "//@" syntax in favor of "//#" syntax is actively being discussed on the dev-js-sourcemap mozilla mailing list, because of issues with JS conditional compilation IE:

It made it into the Source Map Spec:

>    May 16, 2013 - John Lenz
>    Updated linking convention to use # instead of @. @ conflicts with internet explorer’s conditional code

And a note about the previously deprecated syntax (which we should still support):

>    Note: The prefix for this annotation was initially “//@” however this conflicts with
>    Internet Explorer’s conditional comments and was changed to “//#”.  It is reasonable
>    for tools to also accept “//@” but “//#” is preferred.
Comment 1 Joseph Pecoraro 2013-05-16 22:22:39 PDT
Comment 2 Joseph Pecoraro 2013-05-16 22:53:23 PDT
Created attachment 202047 [details]
[PATCH] Proposed Fix

Support # or @ for sourceMappingURL and sourceURL.
Comment 3 WebKit Commit Bot 2013-05-17 05:30:21 PDT
Comment on attachment 202047 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 202047

Committed r150251: <http://trac.webkit.org/changeset/150251>
Comment 4 WebKit Commit Bot 2013-05-17 05:30:23 PDT
All reviewed patches have been landed.  Closing bug.