Bug 116259 – REGRESSION(r150169): http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html fails

• Status: NEW
• Component: Page Loading

[Ryosuke Niwa]

http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html started failing after http://trac.webkit.org/changeset/150169.

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fcache%2Fwillsendrequest-returns-null-for-memory-cache-load.html

The test is also failing on EFL and GTK+ WK1 builders as well.

[Andy Estes]

Hmm, on my machine the test passes when I run all of http/ but fails when I run it by itself.

[Alexey Proskuryakov]

This is still an issue. The test used to be marked as failing on WK2, but it also sometimes fails on WK1 depending on which tests ran before it, so I'm moving the expectation to platform/mac.

[Marcos Chavarría Teijeiro (irc: chavaone)]

This issue is also happening on the GTK port. I'm going to update the platform TestExpectations file.

[Hercules Hjalmarsson]

REGRESSION(252611@main) http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html is a constant crash.

This is now consistently crashing on macOS ToT and since 252611@main. Before that it was failing expectedly.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fcache%2Fwillsendrequest-returns-null-for-memory-cache-load.html

DIFF:
No crash log found for DumpRenderTree:21314.

stdout:

stderr:
ASSERTION FAILED: error.isCancellation()
loader/ResourceLoadNotifier.cpp(189) : void WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages(WebCore::DocumentLoader *, WebCore::ResourceLoaderIdentifier, const WebCore::ResourceRequest &, const WebCore::ResourceResponse &, const WebCore::SharedBuffer *, int, int, const WebCore::ResourceError &)
1   0x102585990 WTFCrash
2   0x12b153ec0 WebCore::JSDOMGlobalObject* JSC::jsCast<WebCore::JSDOMGlobalObject*, JSC::JSGlobalObject>(JSC::JSGlobalObject*)
3   0x12ee7acb8 WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages(WebCore::DocumentLoader*, WTF::ObjectIdentifier<WebCore::ResourceLoader>, WebCore::ResourceRequest const&, WebCore::ResourceResponse const&, WebCore::SharedBuffer const*, int, int, WebCore::ResourceError const&)
4   0x12edfb7fc WebCore::FrameLoader::loadedResourceFromMemoryCache(WebCore::CachedResource&, WebCore::ResourceRequest&, WebCore::ResourceError&)
5   0x12ef3b5b8 WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache(WebCore::CachedResourceRequest const&, WebCore::CachedResource&, WebCore::ResourceError&)
6   0x12ef388fc WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&&, WebCore::CachedResourceLoader::ForPreload, WebCore::ImageLoading)
7   0x12ef3688c WebCore::CachedResourceLoader::requestImage(WebCore::CachedResourceRequest&&, WebCore::ImageLoading)
8   0x12ee1f6e8 WebCore::ImageLoader::updateFromElement(WebCore::RelevantMutation)
9   0x12ee20028 WebCore::ImageLoader::updateFromElementIgnoringPreviousError(WebCore::RelevantMutation)
10  0x12e5f6324 WebCore::HTMLImageElement::selectImageSource(WebCore::RelevantMutation)
11  0x12e5f6878 WebCore::HTMLImageElement::parseAttribute(WebCore::QualifiedName const&, WTF::AtomString const&)
12  0x12e13df74 WebCore::Element::attributeChanged(WebCore::QualifiedName const&, WTF::AtomString const&, WTF::AtomString const&, WebCore::Element::AttributeModificationReason)
13  0x12e2df208 WebCore::StyledElement::attributeChanged(WebCore::QualifiedName const&, WTF::AtomString const&, WTF::AtomString const&, WebCore::Element::AttributeModificationReason)
14  0x12e5f6520 WebCore::HTMLImageElement::attributeChanged(WebCore::QualifiedName const&, WTF::AtomString const&, WTF::AtomString const&, WebCore::Element::AttributeModificationReason)
15  0x12e140bf0 WebCore::Element::parserSetAttributes(WTF::Vector<WebCore::Attribute, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)
16  0x12e88ee74 WebCore::setAttributes(WebCore::Element&, WTF::Vector<WebCore::Attribute, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, WebCore::HasDuplicateAttribute, WebCore::ParserContentPolicy)
17  0x12e88c4a8 WebCore::setAttributes(WebCore::Element&, WebCore::AtomHTMLToken&, WebCore::ParserContentPolicy)
18  0x12e88eba4 WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface(WebCore::AtomHTMLToken&, WebCore::JSCustomElementInterface**)
19  0x12e88e0e0 WebCore::HTMLConstructionSite::createHTMLElement(WebCore::AtomHTMLToken&)
20  0x12e88ef8c WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement(WebCore::AtomHTMLToken&&)
21  0x12e8cd38c WebCore::HTMLTreeBuilder::processStartTagForInBody(WebCore::AtomHTMLToken&&)
22  0x12e8c7484 WebCore::HTMLTreeBuilder::processStartTag(WebCore::AtomHTMLToken&&)
23  0x12e8c6838 WebCore::HTMLTreeBuilder::processToken(WebCore::AtomHTMLToken&&)
24  0x12e8c5660 WebCore::HTMLTreeBuilder::constructTree(WebCore::AtomHTMLToken&&)
25  0x12e89bbe8 WebCore::HTMLDocumentParser::constructTreeFromHTMLToken(WebCore::HTMLTokenizer::TokenPtr&)
26  0x12e89b96c WebCore::HTMLDocumentParser::pumpTokenizerLoop(WebCore::HTMLDocumentParser::SynchronousMode, bool, WebCore::PumpSession&)
27  0x12e89abb8 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode)
28  0x12e89a3ec WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode)
29  0x12e89c3cc WebCore::HTMLDocumentParser::append(WTF::RefPtr<WTF::StringImpl, WTF::RawPtrTraits<WTF::StringImpl>, WTF::DefaultRefDerefTraits<WTF::StringImpl> >&&, WebCore::HTMLDocumentParser::SynchronousMode)
30  0x12e89c200 WebCore::HTMLDocumentParser::append(WTF::RefPtr<WTF::StringImpl, WTF::RawPtrTraits<WTF::StringImpl>, WTF::DefaultRefDerefTraits<WTF::StringImpl> >&&)
31  0x12e034b34 WebCore::DecodedDataDocumentParser::flush(WebCore::DocumentWriter&)

DIFF URL:
https://build.webkit.org/results/Apple-BigSur-Debug-AppleSilicon-WK1-Tests/252613@main%20(7489)/http/tests/cache/willsendrequest-returns-null-for-memory-cache-load-crash-log.txt

[Hercules Hjalmarsson]

I was able to bisect this issue to 252611@main by running command:

run-webkit-tests --debug http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html

Build 252610@main (macOS Debug) is only available by downloading it similar to the bots.

[Radar WebKit Bug Importer]

<rdar://problem/98084903>

[Hercules Hjalmarsson]

To clarify:

This is now consistently crashing on macOS (Debug) ToT and since 252611@main.

[Chris Dumez]

(In reply to Hercules Hjalmarsson from comment #7)
> To clarify:
> 
> This is now consistently crashing on macOS (Debug) ToT and since 252611@main.

Reusing this very old bug about the test failing to track a recent crash regression is not a good idea. Please file a separate issue.

[Hercules Hjalmarsson]

(In reply to Chris Dumez from comment #8)
> (In reply to Hercules Hjalmarsson from comment #7)
> > To clarify:
> > 
> > This is now consistently crashing on macOS (Debug) ToT and since 252611@main.
> 
> Reusing this very old bug about the test failing to track a recent crash
> regression is not a good idea. Please file a separate issue.

Filed new bug, rdar://98127995 to track crash regression.

[Alexey Proskuryakov]

The current state is that the recently regressed assertion is fixed; the test continues to 100% fail on all bots.

The test fully relies on loading callback logging:

@@ -1,9 +1,9 @@
-http://127.0.0.1:8000/misc/resources/compass.jpg - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/resources/compass.jpg, main document URL (null), http method GET> redirectResponse (null)
+http://127.0.0.1:8000/misc/resources/compass.jpg - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/resources/compass.jpg, main document URL http://127.0.0.1:8000/cache/willsendrequest-returns-null-for-memory-cache-load.html, http method GET> redirectResponse (null)
+http://127.0.0.1:8000/cache/willsendrequest-returns-null-for-memory-cache-load.html - didFinishLoading
 http://127.0.0.1:8000/misc/resources/compass.jpg - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/misc/resources/compass.jpg, http status code 200>
 http://127.0.0.1:8000/misc/resources/compass.jpg - didFinishLoading
-http://127.0.0.1:8000/cache/willsendrequest-returns-null-for-memory-cache-load.html - didFinishLoading
 http://127.0.0.1:8000/cache/resources/cached-image.html - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/cache/resources/cached-image.html, main document URL http://127.0.0.1:8000/cache/willsendrequest-returns-null-for-memory-cache-load.html, http method GET> redirectResponse (null)
 http://127.0.0.1:8000/cache/resources/cached-image.html - didReceiveResponse <NSURLResponse http://127.0.0.1:8000/cache/resources/cached-image.html, http status code 200>
 http://127.0.0.1:8000/misc/resources/compass.jpg - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/resources/compass.jpg, main document URL (null), http method GET> redirectResponse (null)
-http://127.0.0.1:8000/misc/resources/compass.jpg - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -999, failing URL "http://127.0.0.1:8000/misc/resources/compass.jpg">
+http://127.0.0.1:8000/misc/resources/compass.jpg - didFailLoadingWithError: <NSError domain WebKitErrorDomain, code 103, failing URL "http://127.0.0.1:8000/misc/resources/compass.jpg">

[Radar WebKit Bug Importer]

<rdar://problem/98644331>