Bug 116254 - Remove WKBundlePageGetHeaderLayer/Footer SPI
Summary: Remove WKBundlePageGetHeaderLayer/Footer SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 17:11 PDT by Beth Dakin
Modified: 2013-05-16 22:22 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.28 KB, patch)
2013-05-16 17:12 PDT, Beth Dakin 		benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-05-16 17:11:27 PDT 
We should remove the Remove WKBundlePageGetHeaderLayer/Footer SPI. It was only recently added and have been replaced by WKBundlePageSetHeaderBanner/Footer.
Comment 1 Beth Dakin 2013-05-16 17:12:01 PDT 
Created attachment 202005 [details]
Patch
Comment 2 Benjamin Poulain 2013-05-16 17:33:04 PDT 
Comment on attachment 202005 [details]
Patch

A changelog would be nice ;)
Comment 3 Benjamin Poulain 2013-05-16 17:33:36 PDT 
Comment on attachment 202005 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202005&action=review

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:826
> +{    

Extra spaces here.
Comment 4 Beth Dakin 2013-05-16 21:42:23 PDT 
(In reply to comment #2)
> (From update of attachment 202005 [details])
> A changelog would be nice ;)

Heh, good call. Thanks for the review!
Comment 5 Beth Dakin 2013-05-16 22:22:54 PDT 
http://trac.webkit.org/changeset/150243