WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
116254
Remove WKBundlePageGetHeaderLayer/Footer SPI
https://bugs.webkit.org/show_bug.cgi?id=116254
Summary
Remove WKBundlePageGetHeaderLayer/Footer SPI
Beth Dakin
Reported
2013-05-16 17:11:27 PDT
We should remove the Remove WKBundlePageGetHeaderLayer/Footer SPI. It was only recently added and have been replaced by WKBundlePageSetHeaderBanner/Footer.
Attachments
Patch
(11.28 KB, patch)
2013-05-16 17:12 PDT
,
Beth Dakin
benjamin
: review+
benjamin
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2013-05-16 17:12:01 PDT
Created
attachment 202005
[details]
Patch
Benjamin Poulain
Comment 2
2013-05-16 17:33:04 PDT
Comment on
attachment 202005
[details]
Patch A changelog would be nice ;)
Benjamin Poulain
Comment 3
2013-05-16 17:33:36 PDT
Comment on
attachment 202005
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=202005&action=review
> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:826 > +{
Extra spaces here.
Beth Dakin
Comment 4
2013-05-16 21:42:23 PDT
(In reply to
comment #2
)
> (From update of
attachment 202005
[details]
) > A changelog would be nice ;)
Heh, good call. Thanks for the review!
Beth Dakin
Comment 5
2013-05-16 22:22:54 PDT
http://trac.webkit.org/changeset/150243
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug