Bug 116252 - [CSS Regions][CSS Exclusions] shape-inside on regions should respect positioned shapes and overflow
Summary: [CSS Regions][CSS Exclusions] shape-inside on regions should respect position...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks: 89256 115001
  Show dependency treegraph
 
Reported: 2013-05-16 16:33 PDT by Zoltan Horvath
Modified: 2013-05-20 13:11 PDT (History)
4 users (show)

See Also:


Attachments
proposed patch (12.17 KB, patch)
2013-05-16 16:53 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff
proposed patch (12.15 KB, patch)
2013-05-16 16:58 PDT, Zoltan Horvath
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2013-05-16 16:33:35 PDT
Shape-inside on regions should respect positioned shapes and overflow.
Comment 1 Zoltan Horvath 2013-05-16 16:53:02 PDT
Created attachment 202003 [details]
proposed patch
Comment 2 Zoltan Horvath 2013-05-16 16:58:07 PDT
Created attachment 202004 [details]
proposed patch

I can compare int with LayoutUnit, so I changed 1 line.
Comment 3 Dave Hyatt 2013-05-20 11:39:16 PDT
Comment on attachment 202004 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202004&action=review

r=me

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1729
> +            LayoutUnit height = exclusionShapeInsideInfo->shapeLogicalTop() - absoluteLogicalTop;

Minor nitpick. Call this logicalHeight and not just height.
Comment 4 Zoltan Horvath 2013-05-20 12:00:38 PDT
Comment on attachment 202004 [details]
proposed patch

Thanks for the review.
Updated and landed in http://trac.webkit.org/changeset/150375