Bug 116251 – [wk2] didGetImageForFindMatch can return a null image

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

FindController::getFindIndicatorBitmapAndRect says:

// Selection rect can be empty for matches that are currently obscured from view.

And then returns a null handle. Which we then try to create a ShareableBitmap from, and then a WebImage from that. We end up getting a null ShareableBitmap in debug builds, or crashing when trying to use the WebImage in release builds (because m_bitmap is null).

We should not didGetImageForFindMatch if we didn't get an image for the find match...

<rdar://problem/13277246>

[Tim Horton]

Created attachment 201999 [details]
patch

[WebKit Commit Bot]

Attachment 201999 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tim Horton]

Comment on attachment 201999 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201999&action=review

> Source/WebKit2/ChangeLog:4
> +        https://bugs.webkit.org/process_bug.cgi

:\

[Simon Fraser (smfr)]

Comment on attachment 201999 [details]
patch

r=me if you fix stuff.

[Tim Horton]

http://trac.webkit.org/changeset/150212