RESOLVED FIXED 116247
filter-build-webkit: Don't filter out the location of the missing symbol when linking fails 
https://bugs.webkit.org/show_bug.cgi?id=116247
Summary filter-build-webkit: Don't filter out the location of the missing symbol when...
David Kilzer (:ddkilzer)
Reported 2013-05-16 14:35:10 PDT
I keep seeing linker failures through filter-build-webkit that don't show the "blame" line due to the overzealous filtering.
Attachments
Patch 1 of 3 (1.83 KB, patch)
2013-05-16 14:46 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch 2 of 3 (29.00 KB, patch)
2013-05-16 14:47 PDT, David Kilzer (:ddkilzer) 		benjamin: review+
DetailsFormatted DiffDiff
Patch 3 of 3 (6.91 KB, patch)
2013-05-16 14:48 PDT, David Kilzer (:ddkilzer) 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2013-05-16 14:46:41 PDT
Created attachment 201990 [details] Patch 1 of 3
David Kilzer (:ddkilzer)
Comment 2 2013-05-16 14:47:29 PDT
Created attachment 201991 [details] Patch 2 of 3
David Kilzer (:ddkilzer)
Comment 3 2013-05-16 14:48:08 PDT
Created attachment 201992 [details] Patch 3 of 3
Benjamin Poulain
Comment 4 2013-05-16 15:38:14 PDT
Comment on attachment 201991 [details] Patch 2 of 3 I don't know anything about perl testing, gotta trust you on this one.
Benjamin Poulain
Comment 5 2013-05-16 15:41:55 PDT
Comment on attachment 201992 [details] Patch 3 of 3 View in context: https://bugs.webkit.org/attachment.cgi?id=201992&action=review > Tools/Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:112 > + my $lineLength = 200; lineLength -> maxLineLength?
WebKit Commit Bot
Comment 6 2013-05-17 10:33:56 PDT
Comment on attachment 201990 [details] Patch 1 of 3 Clearing flags on attachment: 201990 Committed r150272: <http://trac.webkit.org/changeset/150272>
David Kilzer (:ddkilzer)
Comment 7 2013-05-17 12:33:52 PDT
Part 2: Committed r150285. <http://trac.webkit.org/changeset/150285> Part 3: Committed r150286. <http://trac.webkit.org/changeset/150286>
Note You need to log in before you can comment on or make changes to this bug.