Bug 116240 - [Mac] fast/flexbox/auto-height-with-flex.html fails intermittently
Summary: [Mac] fast/flexbox/auto-height-with-flex.html fails intermittently
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 12:12 PDT by Ryosuke Niwa
Modified: 2013-05-17 11:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.87 KB, patch)
2013-05-17 10:37 PDT, Dave Hyatt 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-05-16 12:12:50 PDT 
fast/flexbox/auto-height-with-flex.html has been failing intermittently on Mac release builders ever since they were added:
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fflexbox%2Fauto-height-with-flex.html

e.g.
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK1%20(Tests)/r150193%20(10028)/results.html
Comment 1 Ryosuke Niwa 2013-05-16 12:19:06 PDT 
http://trac.webkit.org/changeset/150201
Comment 2 Dave Hyatt 2013-05-17 10:37:03 PDT 
Created attachment 202117 [details]
Patch
Comment 3 Darin Adler 2013-05-17 10:43:00 PDT 
Comment on attachment 202117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=202117&action=review

r=me but consider my better if condition

> Source/WebCore/rendering/RenderFlexibleBox.cpp:529
> +        if (contentLogicalHeight == LayoutUnit::max())
> +            contentLogicalHeight -= borderPaddingAndScrollbar;

This should be:

    if (contentLogicalHeight > LayoutUnit::max() - borderPaddingAndScrollbar)

It’s also awkward to change contentLogicalHeight in place.
Comment 4 Dave Hyatt 2013-05-17 11:40:58 PDT 
Fixed in r150278.