Bug 116235 - Add stubs for ContextMenu and ContextMenuItem
Summary: Add stubs for ContextMenu and ContextMenuItem
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
Depends on:
Blocks: 111874
  Show dependency treegraph
Reported: 2013-05-16 11:10 PDT by Jesus Sanchez-Palencia
Modified: 2013-05-16 20:28 PDT (History)
4 users (show)

See Also:

Patch (15.48 KB, patch)
2013-05-16 11:36 PDT, Jesus Sanchez-Palencia
no flags Details | Formatted Diff | Diff
Patch (15.49 KB, patch)
2013-05-16 12:36 PDT, Jesus Sanchez-Palencia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2013-05-16 11:10:17 PDT
Ports relying on ENABLE(CROSS_PLATFORM_CONTEXT_MENU) only need a stub implementation for their ContextMenu and ContextMenuItem. We should add defaults ContextMenuItemCommon.cpp and ContextMenuCommon.cpp to be shared between these ports, and remove the duplicated files.
Comment 1 Jesus Sanchez-Palencia 2013-05-16 11:36:32 PDT
Created attachment 201976 [details]
Comment 2 Antonio Gomes 2013-05-16 12:02:06 PDT
Comment on attachment 201976 [details]

Lets use the *None.cpp pattern to name these files.
Comment 3 Jesus Sanchez-Palencia 2013-05-16 12:36:00 PDT
Created attachment 201982 [details]
Comment 4 WebKit Commit Bot 2013-05-16 20:28:23 PDT
Comment on attachment 201982 [details]

Clearing flags on attachment: 201982

Committed r150240: <http://trac.webkit.org/changeset/150240>
Comment 5 WebKit Commit Bot 2013-05-16 20:28:26 PDT
All reviewed patches have been landed.  Closing bug.