Bug 116230 - Missing UNUSED_PARAM macro for textPosition argument in WebKitAccessibleInterfaceText
Summary: Missing UNUSED_PARAM macro for textPosition argument in WebKitAccessibleInter...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-16 08:56 PDT by Eduardo Lima Mitev
Modified: 2013-05-16 20:16 PDT (History)
7 users (show)

See Also:


Attachments
patch (2.08 KB, patch)
2013-05-16 09:02 PDT, Eduardo Lima Mitev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eduardo Lima Mitev 2013-05-16 08:56:58 PDT
webkitAccessibleTextGetTextForOffset() method in WebKitAccessibleInterfaceText is only implemented by GTK port, however the 'textPosition' argument is not listed as unused param for the rest of the ports, causing a warning.
Comment 1 Eduardo Lima Mitev 2013-05-16 09:02:31 PDT
Created attachment 201963 [details]
patch
Comment 2 Mario Sanchez Prada 2013-05-16 09:13:01 PDT
Comment on attachment 201963 [details]
patch

Looks good to me, sorry for having forgotten about this in the first place
Comment 3 WebKit Commit Bot 2013-05-16 20:16:54 PDT
Comment on attachment 201963 [details]
patch

Clearing flags on attachment: 201963

Committed r150236: <http://trac.webkit.org/changeset/150236>
Comment 4 WebKit Commit Bot 2013-05-16 20:16:56 PDT
All reviewed patches have been landed.  Closing bug.