Bug 116229 – [jhbuild] Should remove the sources directory as well when cleaning

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gustavo Noronha (kov)]

[jhbuild] Should remove the sources directory as well when cleaning

[Gustavo Noronha (kov)]

Created attachment 201962 [details]
Patch

[Gustavo Noronha (kov)]

This build failure resulted from jhbuild not noticing the patches applied to a source tree have changed:

https://webkit-queues.appspot.com/results/484327

Although this is arguably a bug in jhbuild, we have suffered problems with builds failing because the clean was not clean enough before, and I couldn't think of a reason why we should not want a full clean rebuild (including checkout and patching) when changing the jhbuild configuration, so this is my proposal.

[Martin Robinson]

Hrm. Isn't it a bit of pain to redownload everything?

[Gustavo Noronha (kov)]

It is indeed, but I think we change the jhbuild modules seldom enough that the reduced complexity pays off.

[Martin Robinson]

Comment on attachment 201962 [details]
Patch

Okay. We can give it a shot and then rework it if there are mobs outside our houses. :)

[Gustavo Noronha (kov)]

Comment on attachment 201962 [details]
Patch

Clearing flags on attachment: 201962

Committed r150198: <http://trac.webkit.org/changeset/150198>

[Gustavo Noronha (kov)]

All reviewed patches have been landed.  Closing bug.

[Philippe Normand]

This is a radical change... Can't we instead make jhbuild smarter? Removing gigabytes of Source/ without even a confirmation prompt was a bad surprise for me this morning...