Bug 116205 - Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
Summary: Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 115246
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-15 21:49 PDT by Patrick R. Gansterer
Modified: 2013-06-24 07:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.59 KB, patch)
2013-05-15 21:59 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (1.59 KB, patch)
2013-05-15 23:36 PDT, Patrick R. Gansterer 		rniwa: review+
Details | Formatted Diff | Diff
Patch for landing (1.60 KB, patch)
2013-06-24 06:20 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2013-05-15 21:49:52 PDT 
Use SetFilePointer instead of SetFilePointerEx in FileSystemWin
Comment 1 Patrick R. Gansterer 2013-05-15 21:59:42 PDT 
Created attachment 201920 [details]
Patch
Comment 2 Patrick R. Gansterer 2013-05-15 23:36:04 PDT 
Created attachment 201925 [details]
Patch
Comment 3 Ryosuke Niwa 2013-06-14 15:35:00 PDT 
Comment on attachment 201925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201925&action=review

> Source/WebCore/platform/win/FileSystemWin.cpp:336
> +    if (largeOffset.LowPart == 0xFFFFFFFF && GetLastError() != NO_ERROR)

Can we compare LowPart to INVALID_SET_FILE_POINTER instead?
Comment 4 Patrick R. Gansterer 2013-06-24 06:20:09 PDT 
Created attachment 205290 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2013-06-24 07:17:12 PDT 
Comment on attachment 205290 [details]
Patch for landing

Clearing flags on attachment: 205290

Committed r151909: <http://trac.webkit.org/changeset/151909>
Comment 6 WebKit Commit Bot 2013-06-24 07:17:14 PDT 
All reviewed patches have been landed.  Closing bug.