Bug 116198 - makeRGBAFromNSColor throws an exception if given a color in a greyscale colorspace
Summary: makeRGBAFromNSColor throws an exception if given a color in a greyscale color...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-15 18:11 PDT by Tim Horton
Modified: 2013-05-15 18:35 PDT (History)
2 users (show)

See Also:

Attachments
patch (2.21 KB, patch)
2013-05-15 18:19 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-05-15 18:11:15 PDT 
The comment in ColorMac.mm about NSColor things not throwing exceptions is a lie.

<rdar://problem/13904395>
Comment 1 Tim Horton 2013-05-15 18:19:45 PDT 
Created attachment 201904 [details]
patch
Comment 2 Tim Horton 2013-05-15 18:22:00 PDT 
Comment on attachment 201904 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201904&action=review

> Source/WebCore/platform/graphics/mac/ColorMac.mm:63
> +        return makeRGBA(0, 0, 0, 0);

Not sure what a reasonable fallback color is.
Comment 3 Simon Fraser (smfr) 2013-05-15 18:30:24 PDT 
Comment on attachment 201904 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=201904&action=review

> Source/WebCore/platform/graphics/mac/ColorMac.mm:61
> +

Maybe remove this blank line.
Comment 4 Tim Horton 2013-05-15 18:35:12 PDT 
http://trac.webkit.org/changeset/150167